TrueCloudLab/frostfs-sdk-csharp
16
0
Fork 3
Code Issues 5 Pull requests Projects Releases Packages Activity Actions

[#20] Client: Optimize memory usage #21

Merged
PavelGrossSpb merged 1 commit from PavelGrossSpb/frostfs-sdk-csharp:misc/memory_optimization into master 2024-09-04 19:51:24 +00:00
Conversation 0 Commits 1 Files changed 1 +2 -2
PavelGrossSpb commented 2024-08-01 13:19:58 +00:00
Member
Copy link

Avoid memory allocation, use cache and static

Signed-off-by: Pavel Gross p.gross@yando.com

Avoid memory allocation, use cache and static Signed-off-by: Pavel Gross <p.gross@yando.com>
PavelGrossSpb added 1 commit 2024-08-01 13:20:15 +00:00
[#20] Client: Optimize memory usage
All checks were successful
DCO / DCO (pull_request) Successful in 41s
Details
0ddde467cd 
Avoid memory allocation, use cache and static

Signed-off-by: Pavel Gross <p.gross@yando.com>
PavelGrossSpb requested review from dstepanov-yadro 2024-08-01 13:20:53 +00:00
PavelGrossSpb requested review from orikik 2024-08-01 13:20:53 +00:00
dstepanov-yadro reviewed 2024-08-01 14:33:21 +00:00
src/FrostFS.SDK.ClientV2/Mappers/ContainerId.cs Outdated
@ -11,2 +16,3 @@
public static ContainerID ToMessage(this ContainerId model)
{
return new ContainerID
if (!Cache.Owners.TryGetValue(model, out ContainerID? message))
dstepanov-yadro commented 2024-08-01 14:33:21 +00:00
Member
Copy link

Why containerID from owners cache?

Why containerID from owners cache?
PavelGrossSpb commented 2024-08-01 15:04:20 +00:00
Author
Member
Copy link

This is a typo, sure. Fixed.

This is a typo, sure. Fixed.
dstepanov-yadro marked this conversation as resolved
dstepanov-yadro reviewed 2024-08-01 14:38:05 +00:00
dstepanov-yadro left a comment
Member
Copy link

It is hard to review such PR's: this PR for example contains refactorings, functional changes, format changes.

It is hard to review such PR's: this PR for example contains refactorings, functional changes, format changes.
PavelGrossSpb added 1 commit 2024-08-01 15:03:32 +00:00
[#20] Client: Fix typo
All checks were successful
DCO / DCO (pull_request) Successful in 26s
Details
6083834582 
Signed-off-by: Pavel Gross <p.gross@yando.com>
dstepanov-yadro approved these changes 2024-08-01 15:08:00 +00:00
PavelGrossSpb merged commit 6083834582 into master 2024-08-05 07:28:58 +00:00
PavelGrossSpb deleted branch misc/memory_optimization 2024-08-05 07:29:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
orikik
dstepanov-yadro
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-csharp#21
No description provided.
Delete branch "PavelGrossSpb/frostfs-sdk-csharp:misc/memory_optimization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?