From 02c936f397c7bb9e1e7ca4e71b548f4deaaa32a1 Mon Sep 17 00:00:00 2001
From: Dmitrii Stepanov <d.stepanov@yadro.com>
Date: Thu, 2 May 2024 17:13:08 +0300
Subject: [PATCH] [#216] netmap: Add policy decode fuzz test

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
---
 go.mod                       |   1 +
 go.sum                       | Bin 73644 -> 73573 bytes
 netmap/policy_decode_test.go |  26 +++++++++++++-------------
 netmap/policy_fuzz.go        |  14 ++++++++++++++
 netmap/policy_fuzz_test.go   |  17 +++++++++++++++++
 5 files changed, 45 insertions(+), 13 deletions(-)
 create mode 100644 netmap/policy_fuzz.go
 create mode 100644 netmap/policy_fuzz_test.go

diff --git a/go.mod b/go.mod
index d600ded..88eaaf0 100644
--- a/go.mod
+++ b/go.mod
@@ -34,6 +34,7 @@ require (
 	github.com/nspcc-dev/neo-go/pkg/interop v0.0.0-20230615193820-9185820289ce // indirect
 	github.com/nspcc-dev/rfc6979 v0.2.0 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
+	github.com/rogpeppe/go-internal v1.8.1 // indirect
 	github.com/twmb/murmur3 v1.1.8 // indirect
 	go.uber.org/atomic v1.10.0 // indirect
 	go.uber.org/goleak v1.2.1 // indirect
diff --git a/go.sum b/go.sum
index 754d2d7c0241317530350bf784c61723d6ef35f7..f9212b23d73e37420a0a64b4954932902c34c22f 100644
GIT binary patch
delta 247
zcmZ3ppXKR3mJQRmC+qWyY~IULkrA7cnU<zdW}pXzx<&>@h6YAPW`<_Q1_qWuZfa7J
zL7Gvbfn}<GdcIz6eu_edp;dvGPiTdYt6xD>MR`iGx36olUs8o(n0s=NTY*nunz6Z|
zsc%VgSy@$*<K#1?(wpr|Id~?|Yjl}>zCql`LeCInMtZ7mfKP!-L7;znSfz8iX_cva
zeo(oOM{0pzN|L#uUqq6bd4yYbfVOM;<bw^WmOyPtF7QeXO3zL!F)#^rO84+hclIoI
ibSX6n$TRaT$u&(e$qVofFEz;XGELFW-+ZO<##{h~MpIY-

delta 181
zcmaF5k7dn%mJQRmosA4l4NXi9bW_qSlgvzwjZ6|vk`*!xt%BTKiu{V*j8e5-z0wk$
zEOMfXf`TgivI4Vx(tHgp)AL*_OH<0+OOp)^CKvK*Os?jZ7QtrLWCNbK&DGq?Gd52s
z5#rGY8LjV@85U-d60D!99a-pR<W=TxTp1DMmgM9U;#nH(l3nU-p6KN7SmvXhJ^5h0
P*yITfVVh?+o|+2)RmeM^

diff --git a/netmap/policy_decode_test.go b/netmap/policy_decode_test.go
index f42d3b5..536d66b 100644
--- a/netmap/policy_decode_test.go
+++ b/netmap/policy_decode_test.go
@@ -7,50 +7,50 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestDecodeString(t *testing.T) {
-	testCases := []string{
-		`REP 2
+var validPlacementPolicy = []string{
+	`REP 2
 CBF 2
 SELECT 2 FROM *`,
-		`REP 1 IN X
+	`REP 1 IN X
 CBF 1
 SELECT 2 IN SAME Location FROM * AS X`,
 
-		`REP 1 IN X
+	`REP 1 IN X
 REP 2 IN Y
 CBF 1
 SELECT 2 FROM * AS X
 SELECT 3 FROM * AS Y`,
 
-		`REP 1 IN X
+	`REP 1 IN X
 SELECT 2 IN City FROM Good AS X
 FILTER Country EQ RU AS FromRU
 FILTER Country EQ EN AS FromEN
 FILTER @FromRU AND @FromEN AND Rating GT 7 AS Good`,
 
-		`REP 7 IN SPB
+	`REP 7 IN SPB
 SELECT 1 IN City FROM SPBSSD AS SPB
 FILTER City EQ SPB AND SSD EQ true OR City EQ SPB AND Rating GE 5 AS SPBSSD`,
 
-		`REP 7 IN SPB
+	`REP 7 IN SPB
 SELECT 1 IN City FROM SPBSSD AS SPB
 FILTER NOT (NOT (City EQ SPB) AND SSD EQ true OR City EQ SPB AND Rating GE 5) AS SPBSSD`,
 
-		`REP 1 IN FNODE
+	`REP 1 IN FNODE
 CBF 1
 SELECT 1 FROM F AS FNODE
 FILTER Node EQ '10.78.8.11' AS F`,
 
-		`UNIQUE
+	`UNIQUE
 REP 1
 REP 1`,
-		`EC 1.2 IN X
+	`EC 1.2 IN X
 SELECT 3 IN City FROM * AS X`,
-	}
+}
 
+func TestDecodeString(t *testing.T) {
 	var p PlacementPolicy
 
-	for _, testCase := range testCases {
+	for _, testCase := range validPlacementPolicy {
 		require.NoError(t, p.DecodeString(testCase), "unable parse %s", testCase)
 		var b strings.Builder
 		require.NoError(t, p.WriteStringTo(&b))
diff --git a/netmap/policy_fuzz.go b/netmap/policy_fuzz.go
new file mode 100644
index 0000000..40088e9
--- /dev/null
+++ b/netmap/policy_fuzz.go
@@ -0,0 +1,14 @@
+//go:build gofuzz
+// +build gofuzz
+
+package netmap
+
+func DoFuzzPlacementPolicyDecode(data []byte) int {
+	p := string(data)
+	if p == "" {
+		return 0
+	}
+	var pp PlacementPolicy
+	_ = pp.DecodeString(p)
+	return 1
+}
diff --git a/netmap/policy_fuzz_test.go b/netmap/policy_fuzz_test.go
new file mode 100644
index 0000000..35b69a4
--- /dev/null
+++ b/netmap/policy_fuzz_test.go
@@ -0,0 +1,17 @@
+//go:build gofuzz
+// +build gofuzz
+
+package netmap
+
+import (
+	"testing"
+)
+
+func FuzzDecodeString(f *testing.F) {
+	for _, pp := range validPlacementPolicy {
+		f.Add([]byte(pp))
+	}
+	f.Fuzz(func(t *testing.T, data []byte) {
+		DoFuzzPlacementPolicyDecode(data)
+	})
+}