TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

[#261] session: Make failed Sign pure on failed signature calculation

Browse source 
Make `Sign` method implementation to not modify `issuerSet` state
variable after signature calculation's failures.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2022-06-02 17:46:19 +03:00 committed by LeL
parent 0bb40b3245
commit 458c882ff4
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
session/common.go
View file

@ -157,7 +157,6 @@ func (x commonData) signedData(w contextWriter) []byte {
func (x *commonData) sign(key ecdsa.PrivateKey, w contextWriter) error { func (x *commonData) sign(key ecdsa.PrivateKey, w contextWriter) error {
user.IDFromKey(&x.issuer, key.PublicKey) user.IDFromKey(&x.issuer, key.PublicKey)
x.issuerSet = true
var sig neofscrypto.Signature var sig neofscrypto.Signature
@ -166,6 +165,8 @@ func (x *commonData) sign(key ecdsa.PrivateKey, w contextWriter) error {
return err return err
} }
x.issuerSet = true
sig.WriteToV2(&x.sig) sig.WriteToV2(&x.sig)
x.sigSet = true x.sigSet = true