Make ResolveFrostFSFailures the default option. #131

Closed
opened 2023-07-26 11:54:04 +00:00 by fyrchik · 4 comments
Owner

As an SDK user I would expect failed RPCs to return error, unless I am ready to process API-level statuses according to spec.

As an SDK user I would expect failed RPCs to return error, unless I am _ready_ to process API-level statuses according to spec.
fyrchik added the
discussion
good first issue
refactoring
labels 2023-07-26 11:54:04 +00:00
Author
Owner

We may even remove it, as errors.Is is quite common in the Go code.

We may even remove it, as `errors.Is` is quite common in the Go code.
Author
Owner

Let's do it in 2 steps:

  1. Switch default.
  2. Remove completely (and add possibility to extract status from the error)
Let's do it in 2 steps: 1. Switch default. 2. Remove completely (and add possibility to extract status from the error)
Contributor

I would like to take this one. Could you please clarify:

  1. Should each step be divided into separate MRs?
  2. There is already ErrToStatus, which converts the error instance to Status instance. Which additional actions should be done for extracting status from the error?
I would like to take this one. Could you please clarify: 1. Should each step be divided into separate MRs? 2. There is already `ErrToStatus`, which converts the error instance to Status instance. Which additional actions should be done for extracting status from the error?
Author
Owner

Closed via #163.

Closed via #163.
Sign in to join this conversation.
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#131
No description provided.