Make `ResolveFrostFSFailures` the default option. #131

New issue

Closed

opened 2023-07-26 11:54:04 +00:00 by fyrchik · 4 comments

fyrchik commented

2023-07-26 11:54:04 +00:00

Owner

As an SDK user I would expect failed RPCs to return error, unless I am ready to process API-level statuses according to spec.

As an SDK user I would expect failed RPCs to return error, unless I am _ready_ to process API-level statuses according to spec.

fyrchik added the

discussion

good first issue

refactoring

labels 2023-07-26 11:54:04 +00:00

fyrchik commented

2023-07-26 12:00:03 +00:00

Author

Owner

We may even remove it, as errors.Is is quite common in the Go code.

We may even remove it, as `errors.Is` is quite common in the Go code.

fyrchik commented

2023-07-27 10:30:09 +00:00

Author

Owner

Let's do it in 2 steps:

Switch default.
Remove completely (and add possibility to extract status from the error)

Let's do it in 2 steps: 1. Switch default. 2. Remove completely (and add possibility to extract status from the error)

👍 1

olefirenque commented

2023-09-12 15:50:46 +00:00

Contributor

I would like to take this one. Could you please clarify:

Should each step be divided into separate MRs?
There is already ErrToStatus, which converts the error instance to Status instance. Which additional actions should be done for extracting status from the error?

I would like to take this one. Could you please clarify: 1. Should each step be divided into separate MRs? 2. There is already `ErrToStatus`, which converts the error instance to Status instance. Which additional actions should be done for extracting status from the error?