TrueCloudLab
/
frostfs-sdk-go
29
0
Fork 18
Code Issues 29 Pull Requests 3 Actions Releases Activity

client: Refactor accounting.Balance() #143

Merged
fyrchik merged 1 commits from fyrchik/frostfs-sdk-go:fix-client into master 2023-08-10 11:05:31 +00:00
Conversation 1 Commits 1 Files Changed 2
fyrchik commented 2023-08-09 06:48:48 +00:00
Owner

Finally, close #48

Finally, close #48
fyrchik force-pushed fix-client from 38c6b60951 to 0ae56c99ea 2023-08-09 06:48:58 +00:00 Compare
fyrchik requested review from storage-core-committers 2023-08-09 06:49:03 +00:00
fyrchik requested review from storage-core-developers 2023-08-09 06:49:03 +00:00
fyrchik commented 2023-08-09 06:49:28 +00:00
Poster
Owner

LInter started to complain, so everything is in one commit.

LInter started to complain, so everything is in one commit.
acid-ant approved these changes 2023-08-09 07:11:53 +00:00
aarifullin approved these changes 2023-08-10 10:56:40 +00:00
aarifullin left a comment
Collaborator

It's very good that you have introduced buildRequest. It will be helpful for PrmBalanceGet refactoring

It's very good that you have introduced `buildRequest`. It will be helpful for `PrmBalanceGet` refactoring
fyrchik merged commit 548a81d3e6 into master 2023-08-10 11:05:31 +00:00
fyrchik deleted branch fix-client 2023-08-10 11:05:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
aarifullin
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#143
There is no content yet.
Delete Branch "fyrchik/frostfs-sdk-go:fix-client"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?