TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 33 Pull requests 3 Releases Activity Actions

sdk: Remove panic from RPCs #15

Merged
acid-ant merged 2 commits from bugfix/2-do-not-panic into master 2023-03-01 07:29:23 +00:00
Conversation 2 Commits 2 Files changed 17 +92 -90
acid-ant commented 2023-02-06 09:53:40 +00:00 (Migrated from github.com)
Copy link

Partially close #2

Update lint config, fix lint errors

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Partially close #2 Update lint config, fix lint errors Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
carpawell (Migrated from github.com) reviewed 2023-02-06 09:53:40 +00:00
KirillovDenis (Migrated from github.com) reviewed 2023-02-06 09:53:40 +00:00
KirillovDenis commented 2023-02-07 08:02:21 +00:00 (Migrated from github.com)
Copy link

Let's drop tests with go1.17 from github actions

Let's drop tests with go1.17 from github actions
👍 1
KirillovDenis (Migrated from github.com) reviewed 2023-02-07 08:51:20 +00:00
alexvanin commented 2023-02-07 09:32:53 +00:00 (Migrated from github.com)
Copy link

Let's drop tests with go1.17 from github actions

We can also add go1.20 😄

> Let's drop tests with go1.17 from github actions We can also add go1.20 :smile:
👍 1
alexvanin (Migrated from github.com) reviewed 2023-02-07 09:33:21 +00:00
KirillovDenis (Migrated from github.com) reviewed 2023-02-07 11:18:20 +00:00
alexvanin (Migrated from github.com) reviewed 2023-02-07 14:22:48 +00:00
fyrchik (Migrated from github.com) reviewed 2023-02-17 08:52:28 +00:00
.golangci.yml
@ -33,4 +33,3 @@
# some default golangci-lint linters
- deadcode
- errcheck
fyrchik (Migrated from github.com) commented 2023-02-17 08:50:16 +00:00
Copy link

Why?

Why?
pool/mock_test.go
@ -6,3 +6,4 @@
"errors"
"go.uber.org/zap"
fyrchik (Migrated from github.com) commented 2023-02-17 08:52:16 +00:00
Copy link

Unrelated to this commit, could also merge this with the next line.

Unrelated to this commit, could also merge this with the next line.
acid-ant (Migrated from github.com) reviewed 2023-02-17 14:06:18 +00:00
.golangci.yml
@ -33,4 +33,3 @@
# some default golangci-lint linters
- deadcode
- errcheck
acid-ant (Migrated from github.com) commented 2023-02-17 14:06:18 +00:00
Copy link

Deprecated since v1.49.0 of golangci-lint. Replaced by unused.

Deprecated since v1.49.0 of golangci-lint. Replaced by `unused`.
acid-ant (Migrated from github.com) reviewed 2023-02-17 14:10:31 +00:00
pool/mock_test.go
@ -6,3 +6,4 @@
"errors"
"go.uber.org/zap"
acid-ant (Migrated from github.com) commented 2023-02-17 14:10:31 +00:00
Copy link

Reverted. Moved to another commit.

Reverted. Moved to another commit.
KirillovDenis (Migrated from github.com) reviewed 2023-02-20 07:56:19 +00:00
fyrchik (Migrated from github.com) reviewed 2023-02-24 14:32:13 +00:00
client/accounting.go
@ -46,7 +46,7 @@ func (x ResBalanceGet) Amount() accounting.Decimal {
// FrostFS status codes are returned as `error`, otherwise, are included
fyrchik (Migrated from github.com) commented 2023-02-24 14:31:06 +00:00
Copy link

an error

`an error`
fyrchik (Migrated from github.com) commented 2023-02-24 14:31:55 +00:00
Copy link

What about adding a variable for this and other errors touched in this commit?

What about adding a variable for this and other errors touched in this commit?
client/client.go
fyrchik (Migrated from github.com) commented 2023-02-24 14:31:21 +00:00
Copy link

Same here

Same here
acid-ant (Migrated from github.com) reviewed 2023-02-27 08:01:26 +00:00
client/accounting.go
@ -46,7 +46,7 @@ func (x ResBalanceGet) Amount() accounting.Decimal {
// FrostFS status codes are returned as `error`, otherwise, are included
acid-ant (Migrated from github.com) commented 2023-02-27 08:01:25 +00:00
Copy link

Fixed.

Fixed.
acid-ant (Migrated from github.com) reviewed 2023-02-27 08:01:30 +00:00
client/client.go
acid-ant (Migrated from github.com) commented 2023-02-27 08:01:30 +00:00
Copy link

Fixed.

Fixed.
acid-ant (Migrated from github.com) reviewed 2023-02-27 08:04:30 +00:00
client/accounting.go
@ -46,7 +46,7 @@ func (x ResBalanceGet) Amount() accounting.Decimal {
// FrostFS status codes are returned as `error`, otherwise, are included
acid-ant (Migrated from github.com) commented 2023-02-27 08:04:30 +00:00
Copy link

Sounds good, added.

Sounds good, added.
fyrchik (Migrated from github.com) reviewed 2023-02-28 07:39:37 +00:00
.github/workflows/tests.yml
fyrchik (Migrated from github.com) commented 2023-02-28 07:39:36 +00:00
Copy link

This can be dropped after a rebase on master.

This can be dropped after a rebase on master.
fyrchik (Migrated from github.com) reviewed 2023-02-28 07:39:47 +00:00
acid-ant (Migrated from github.com) reviewed 2023-02-28 07:52:18 +00:00
.github/workflows/tests.yml
acid-ant (Migrated from github.com) commented 2023-02-28 07:52:17 +00:00
Copy link

Done.

Done.
fyrchik (Migrated from github.com) approved these changes 2023-02-28 07:55:54 +00:00
dstepanov-yadro (Migrated from github.com) approved these changes 2023-03-01 07:04:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carpawell
KirillovDenis
fyrchik
dstepanov-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#15
No description provided.
Delete branch "bugfix/2-do-not-panic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?