TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 29 Pull requests 1 Releases Activity Actions

[#121] client: Make PrmObjectDelete fields public #157

Merged
fyrchik merged 1 commit from aarifullin/frostfs-sdk-go:feature/121-prm_object_delete into master 2023-09-04 14:14:23 +00:00
Conversation 0 Commits 1 Files changed 2 +72 -85
aarifullin commented 2023-09-04 10:25:04 +00:00
Member
Copy link
  • Introduce buildRequest for PrmObjectDelete
  • Refactor the usage of these params in pool

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

* Introduce buildRequest for PrmObjectDelete * Refactor the usage of these params in pool Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added the
refactoring
 label 2023-09-04 10:25:04 +00:00
aarifullin added 1 commit 2023-09-04 10:25:09 +00:00
[#121] client: Make PrmObjectDelete fields public
All checks were successful
DCO / DCO (pull_request) Successful in 49s
Details
Tests and linters / Tests (1.19) (pull_request) Successful in 1m11s
Details
Tests and linters / Lint (pull_request) Successful in 7m50s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 7m46s
Details
24697d288e 
* Introduce buildRequest for PrmObjectDelete
* Refactor the usage of these params in pool

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin requested review from storage-core-committers 2023-09-04 10:25:20 +00:00
aarifullin requested review from storage-core-developers 2023-09-04 10:25:22 +00:00
aarifullin requested review from storage-services-committers 2023-09-04 10:25:43 +00:00
aarifullin requested review from storage-services-developers 2023-09-04 10:25:44 +00:00
acid-ant approved these changes 2023-09-04 10:33:46 +00:00
fyrchik approved these changes 2023-09-04 14:13:35 +00:00
fyrchik approved these changes 2023-09-04 14:14:15 +00:00
fyrchik merged commit 5a471e5002 into master 2023-09-04 14:14:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#157
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:feature/121-prm_object_delete"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?