TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

[#121] client: Make PrmObjectPutSingle fields public #160

Merged
fyrchik merged 1 commit from aarifullin/frostfs-sdk-go:feature/121-prm_object_put_single into master 2023-10-19 08:38:14 +00:00
Conversation 2 Commits 1 Files changed 5 +191 -87
aarifullin commented 2023-09-07 08:56:14 +00:00
Member
Copy link

Signed-off-by: Airat Arifullin a.arifullin@yadro.com

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin added the
refactoring
 label 2023-09-07 08:56:14 +00:00
aarifullin requested review from storage-core-committers 2023-09-07 08:56:34 +00:00
aarifullin requested review from storage-core-developers 2023-09-07 08:56:35 +00:00
aarifullin requested review from storage-services-committers 2023-09-07 08:56:56 +00:00
aarifullin requested review from storage-services-developers 2023-09-07 08:56:57 +00:00
aarifullin changed title from [#121] client: Make PrmObjectPutSingle fields public to WIP: [#121] client: Make PrmObjectPutSingle fields public 2023-09-07 08:57:35 +00:00
aarifullin force-pushed feature/121-prm_object_put_single from f71e5477e5 to 735d506e8f 2023-09-07 12:50:44 +00:00 Compare
aarifullin changed title from WIP: [#121] client: Make PrmObjectPutSingle fields public to [#121] client: Make PrmObjectPutSingle fields public 2023-09-07 12:51:21 +00:00
aarifullin reviewed 2023-09-07 12:53:01 +00:00
client/object_put_transformer.go Outdated
@ -96,4 +96,0 @@
var prm PrmObjectPutSingle
prm.SetCopiesNumber(it.prm.copyNum)
prm.SetObject(o.ToV2())
prm.UseKey(prm.key)
aarifullin commented 2023-09-07 12:53:01 +00:00
Author
Member
Copy link

It seems this was incorrect

It seems this was incorrect
aarifullin reviewed 2023-09-07 12:53:03 +00:00
fyrchik reviewed 2023-09-07 14:13:24 +00:00
client/object_put_single.go Outdated
@ -24,0 +27,4 @@
CopiesNumber []uint32
Object *v2object.Object
fyrchik commented 2023-09-07 14:13:23 +00:00
Owner
Copy link

Let's not use v2 structs in public fields -- we have object.Object in the SDK

Let's not use v2 structs in public fields -- we have `object.Object` in the SDK
aarifullin commented 2023-09-07 16:09:02 +00:00
Author
Member
Copy link

Awesome point. Sure

Awesome point. Sure
aarifullin commented 2023-09-07 16:18:29 +00:00
Author
Member
Copy link

Fixed

Fixed
fyrchik marked this conversation as resolved
aarifullin force-pushed feature/121-prm_object_put_single from 735d506e8f to c09f60168a 2023-09-07 16:17:58 +00:00 Compare
acid-ant approved these changes 2023-09-08 06:18:28 +00:00
client/object_put.go Outdated
@ -101,2 +119,4 @@
// WithBearerToken attaches bearer token to be used for the operation.
// Should be called once before any writing steps.
//
// Deprecated: Use PrmObjectPutInit.Key instead.
acid-ant commented 2023-09-08 06:14:59 +00:00
Member
Copy link

Key -> BearerToken

Key -> BearerToken
client/object_put_single.go Outdated
@ -51,2 +63,2 @@
t.WriteToV2(tv2)
x.meta.SetSessionToken(tv2)
//
// Deprecated: Use PrmObjectPutSingle.BearerToken instead.
acid-ant commented 2023-09-08 06:10:01 +00:00
Member
Copy link

BearerToken -> Session

BearerToken -> Session
aarifullin commented 2023-09-08 09:29:52 +00:00
Author
Member
Copy link

Thanks!

Thanks!
aarifullin force-pushed feature/121-prm_object_put_single from c09f60168a to 5074bf7276 2023-09-08 09:29:44 +00:00 Compare
aarifullin requested review from acid-ant 2023-10-17 08:25:02 +00:00
fyrchik approved these changes 2023-10-17 08:27:27 +00:00
acid-ant approved these changes 2023-10-17 09:48:18 +00:00
dkirillov commented 2023-10-17 11:40:53 +00:00
Member
Copy link

Can we also update using new approach in pool in this PR? This 5074bf7276/pool/pool.go (L655) is deprecated now

Can we also update using new approach in pool in this PR? This https://git.frostfs.info/aarifullin/frostfs-sdk-go/src/commit/5074bf7276913e39941bbf482ed30ce5802132d6/pool/pool.go#L655 is deprecated now
aarifullin force-pushed feature/121-prm_object_put_single from 5074bf7276 to 9ce6eed5ad 2023-10-19 07:59:12 +00:00 Compare
aarifullin commented 2023-10-19 08:18:49 +00:00
Author
Member
Copy link

Can we also update using new approach in pool in this PR? This 5074bf7276/pool/pool.go (L655) is deprecated now

Done

> Can we also update using new approach in pool in this PR? This https://git.frostfs.info/aarifullin/frostfs-sdk-go/src/commit/5074bf7276913e39941bbf482ed30ce5802132d6/pool/pool.go#L655 is deprecated now Done
aarifullin requested review from fyrchik 2023-10-19 08:18:53 +00:00
aarifullin requested review from acid-ant 2023-10-19 08:18:54 +00:00
acid-ant approved these changes 2023-10-19 08:22:57 +00:00
fyrchik approved these changes 2023-10-19 08:38:09 +00:00
fyrchik merged commit 5804128ff3 into master 2023-10-19 08:38:14 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#160
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:feature/121-prm_object_put_single"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?