TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 32 Pull requests 3 Releases Activity Actions

Use priority of errors in tree pool #176

Merged
alexvanin merged 1 commit from alexvanin/frostfs-sdk-go:fix/172-more-retry into master 2023-10-11 11:44:14 +00:00
Conversation 0 Commits 1 Files changed 2 +40 -4
alexvanin commented 2023-10-11 09:02:04 +00:00
Owner
Copy link

Closes #172

When retry happens, use priority map to decide which error to return. Consider network errors less desirable than business logic errors.

Closes #172 When retry happens, use priority map to decide which error to return. Consider network errors less desirable than business logic errors.
alexvanin self-assigned this 2023-10-11 09:02:04 +00:00
alexvanin added 1 commit 2023-10-11 09:02:08 +00:00
[#172] pool: Use priority of errors in tree pool
All checks were successful
Tests and linters / Tests (1.20) (pull_request) Successful in 1m8s
Details
Tests and linters / Lint (pull_request) Successful in 1m33s
Details
DCO / DCO (pull_request) Successful in 5m8s
Details
Tests and linters / Tests (1.19) (pull_request) Successful in 1m2s
Details
fc4551b843 
When retry happens, use priority map to decide
which error to return. Consider network errors
less desirable than business logic errors.

Signed-off-by: Alex Vanin <a.vanin@yadro.com>
requested reviews from fyrchik, dkirillov, pogpp, ironbee 2023-10-11 09:02:50 +00:00
dkirillov approved these changes 2023-10-11 09:42:48 +00:00
acid-ant approved these changes 2023-10-11 11:26:08 +00:00
alexvanin merged commit fc4551b843 into master 2023-10-11 11:44:14 +00:00
alexvanin deleted branch fix/172-more-retry 2023-10-11 11:44:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
pogpp
ironbee
dkirillov
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
alexvanin
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#176
No description provided.
Delete branch "alexvanin/frostfs-sdk-go:fix/172-more-retry"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?