TrueCloudLab
/
frostfs-sdk-go
28
0
Fork 18
Code Issues 28 Pull Requests 4 Actions Releases Activity

client: Make PrmObjectSearch fields public #179

Merged
fyrchik merged 2 commits from aarifullin/frostfs-sdk-go:feature/121-prm_object_search into master 2023-11-02 06:40:05 +00:00
Conversation 0 Commits 2 Files Changed 2
aarifullin commented 2023-10-23 14:00:24 +00:00
Collaborator

Make PrmObjectSearch fields public avoiding v2-api types and using only sdk types.
Refactor its usage within pool

Make PrmObjectSearch fields public avoiding v2-api types and using only sdk types. Refactor its usage within pool
aarifullin added the
refactoring
 label 2023-10-23 14:00:24 +00:00
aarifullin requested review from storage-core-committers 2023-10-23 14:00:33 +00:00
aarifullin requested review from storage-core-developers 2023-10-23 14:00:34 +00:00
aarifullin requested review from storage-services-committers 2023-10-23 14:00:44 +00:00
aarifullin requested review from storage-services-developers 2023-10-23 14:00:48 +00:00
aarifullin changed title from client: Make PrmObjectSearch fields public to WIP: client: Make PrmObjectSearch fields public 2023-10-23 14:34:28 +00:00
aarifullin changed title from WIP: client: Make PrmObjectSearch fields public to client: Make PrmObjectSearch fields public 2023-10-24 08:34:51 +00:00
dkirillov approved these changes 2023-10-24 11:42:47 +00:00
dkirillov left a comment
Collaborator

LGTM

LGTM
dstepanov-yadro requested changes 2023-10-24 12:58:56 +00:00
client/object_search.go Outdated
@ -57,2 +64,4 @@
//
// Must be signed.
//
// Deprecated: Use PrmObjectSearch.BearerToken instead.
dstepanov-yadro commented 2023-10-24 12:58:54 +00:00
Collaborator

make lint fails.

`make lint` fails.
aarifullin commented 2023-11-01 15:31:57 +00:00
Poster
Collaborator

Fixed

Fixed
acid-ant approved these changes 2023-10-25 06:50:24 +00:00
aarifullin force-pushed feature/121-prm_object_search from 02e30ce5ba to e2c93b0a94 2023-10-26 07:50:27 +00:00 Compare
aarifullin changed title from client: Make PrmObjectSearch fields public to WIP: client: Make PrmObjectSearch fields public 2023-10-26 07:53:14 +00:00
aarifullin force-pushed feature/121-prm_object_search from e2c93b0a94 to 6fbe1595cb 2023-11-01 14:45:39 +00:00 Compare
aarifullin changed title from WIP: client: Make PrmObjectSearch fields public to client: Make PrmObjectSearch fields public 2023-11-01 14:45:50 +00:00
aarifullin requested review from dstepanov-yadro 2023-11-01 15:03:53 +00:00
aarifullin requested review from acid-ant 2023-11-01 15:03:53 +00:00
aarifullin requested review from dkirillov 2023-11-01 15:03:54 +00:00
fyrchik approved these changes 2023-11-01 15:28:52 +00:00
dstepanov-yadro approved these changes 2023-11-01 15:35:43 +00:00
acid-ant approved these changes 2023-11-02 06:08:06 +00:00
dkirillov approved these changes 2023-11-02 06:22:00 +00:00
fyrchik merged commit 6fbe1595cb into master 2023-11-02 06:40:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dstepanov-yadro
acid-ant
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#179
There is no content yet.
Delete Branch "aarifullin/frostfs-sdk-go:feature/121-prm_object_search"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?