TrueCloudLab
/
frostfs-sdk-go
28
0
Fork 18
Code Issues 28 Pull Requests 4 Actions Releases Activity

Make linter great again #183

Merged
dstepanov-yadro merged 1 commits from dstepanov-yadro/frostfs-sdk-go:feat/linters into master 2023-10-23 15:28:58 +00:00
Conversation 0 Commits 1 Files Changed 3
dstepanov-yadro commented 2023-10-23 15:06:04 +00:00
Collaborator

Add custom linters from git.frostfs.info/TrueCloudLab/linters

Fix Go versions

Add custom linters from git.frostfs.info/TrueCloudLab/linters Fix Go versions
dstepanov-yadro force-pushed feat/linters from e27fd8d3a7 to 7a4d97a06d 2023-10-23 15:06:57 +00:00 Compare
dstepanov-yadro force-pushed feat/linters from 7a4d97a06d to 71335489ae 2023-10-23 15:14:11 +00:00 Compare
dstepanov-yadro requested review from storage-core-committers 2023-10-23 15:14:20 +00:00
dstepanov-yadro requested review from storage-core-developers 2023-10-23 15:14:21 +00:00
aarifullin approved these changes 2023-10-23 15:19:53 +00:00
fyrchik approved these changes 2023-10-23 15:20:08 +00:00
Makefile
@ -18,0 +24,4 @@
lint-install:
@mkdir -p $(TMP_DIR)
@rm -rf $(TMP_DIR)/linters
@git -c advice.detachedHead=false clone --branch v$(TRUECLOUDLAB_LINT_VERSION) https://git.frostfs.info/TrueCloudLab/linters.git $(TMP_DIR)/linters
fyrchik commented 2023-10-23 15:19:59 +00:00
Owner

Do we need this here?

Do we need this here?
dstepanov-yadro commented 2023-10-23 15:21:17 +00:00
Poster
Collaborator

Why not? There are not only log linter

Why not? There are not only log linter
👍 1
dstepanov-yadro merged commit 71335489ae into master 2023-10-23 15:28:58 +00:00
dstepanov-yadro deleted branch feat/linters 2023-10-23 15:28:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
aarifullin
fyrchik
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#183
There is no content yet.
Delete Branch "dstepanov-yadro/frostfs-sdk-go:feat/linters"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?