Use typed HRW methods #21

2023-02-27T14:25:14Z

dstepanov-yadro commented

2023-02-27 14:25:14 +00:00

(Migrated from github.com)

Update HRW pkg and use typed HRW methods to sort nodes

alexvanin (Migrated from github.com) reviewed 2023-02-27 14:25:14 +00:00

ale64bit (Migrated from github.com) reviewed 2023-02-27 14:25:14 +00:00

fyrchik (Migrated from github.com) reviewed 2023-02-27 14:58:47 +00:00

netmap/netmap.go

													
				@ -154,3 +154,3 @@

						copy(result[i], vectors[i])

						hrw.SortSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

						hrw.SortHasherSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

					}

fyrchik (Migrated from github.com) commented

2023-02-27 14:54:23 +00:00

Can we do an optimization with hash precalculation, similar to what you've done in the frostfs-node?

Should be done in readFromV2 and SetPublicKey functions. We should also fallback to a normal calculation if the hash is 0. Am I missing something here? @carpawell

Can we do an optimization with hash precalculation, similar to what you've done in the `frostfs-node`? Should be done in `readFromV2` and `SetPublicKey` functions. We should also fallback to a normal calculation if the hash is 0. Am I missing something here? @carpawell

dstepanov-yadro (Migrated from github.com) reviewed 2023-02-27 15:41:20 +00:00

netmap/netmap.go

													
				@ -154,3 +154,3 @@

						copy(result[i], vectors[i])

						hrw.SortSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

						hrw.SortHasherSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

					}

dstepanov-yadro (Migrated from github.com) commented

2023-02-27 15:41:19 +00:00

done

fyrchik (Migrated from github.com) reviewed 2023-02-28 07:37:35 +00:00

netmap/netmap.go

													
				@ -154,3 +154,3 @@

						copy(result[i], vectors[i])

						hrw.SortSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

						hrw.SortHasherSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

					}

fyrchik (Migrated from github.com) commented

2023-02-28 07:37:34 +00:00

Could you mention about this in the commit message? Actually, a separate commit for this specific opitimization would be nice.

acid-ant (Migrated from github.com) reviewed 2023-02-28 08:45:49 +00:00

dstepanov-yadro (Migrated from github.com) reviewed 2023-02-28 11:07:08 +00:00

netmap/netmap.go

													
				@ -154,3 +154,3 @@

						copy(result[i], vectors[i])

						hrw.SortSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

						hrw.SortHasherSliceByWeightValue(result[i], nodes(result[i]).weights(wf), h)

					}