Introduce apemanager rpc interface #215
No reviewers
Labels
No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: TrueCloudLab/frostfs-sdk-go#215
Loading…
Reference in a new issue
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:feat/apemanager"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Chain
,ChainTarget
andTargetType
.client: Introduce apemanager rpc interface
APEManagerAddChain
,APEManagerRemoveChain
,APEManagerListChains
.APEManagerAccessDenied
; add unit-tests.7e44e49aa7
tod01e6fbbe4
d01e6fbbe4
to0cc57a80eb
0cc57a80eb
to5da49255eb
5da49255eb
to93c8923d33
93c8923d33
to60a3fb7066
60a3fb7066
to7deda2f8c9
WIP: [#XX] client: apemanagerto Introduce apemanager rpc interface@ -0,0 +10,4 @@
type Chain struct {
// Raw is the encoded chain representation.
Raw *[]byte
[]byte
is already a pointer type, what is the reason for double indirection?Nevermind :). Fixed. I just wanted to make a validator and check if
Raw
was set but actually ifRaw
is not set then it is leftnil
without this pointer anyway.7deda2f8c9
to2698bb9f12
2698bb9f12
to1852e8991e
@ -0,0 +37,4 @@
apemanager.WriteAccessDeniedDesc(&x.v2, reason)
}
func (x APEManagerAccessDenied) Reason() string {
Please, let's write doc-comments for public methods.
Alright. I've added comments. Please check them out
1852e8991e
tob59a96328e
b59a96328e
tod7956ee197
d7956ee197
tobfe8d7a25b
FYI: I had put changes to
Error()
method and I have rolled them back. So, there are no changes after these two approvals@ -0,0 +60,4 @@
filledFieldCount++
}
if filledFieldCount != 1 {
You are calling this method each time when build requests, why not to make this check simpler just with
c.Raw != nil
?Removed
CheckValidity
out :) (see comment below)@ -0,0 +53,4 @@
// CheckValidity checks if Chain is correctly formed from the point of
// its kind: it should not be empty and only one kind is allowed.
func (c *Chain) CheckValidity() error {
What is the purpose of this method? We have oneof already on the API boundary.
You're right, I didn't think about that. Removed
CheckValidity
outbfe8d7a25b
tob2ad1f3b3e