TrueCloudLab
/
frostfs-sdk-go
31
0
Fork 19
Code Issues 29 Pull Requests 3 Actions Releases Activity

object: Introduce new fields for ECHeader type #223

Merged
fyrchik merged 3 commits from aarifullin/frostfs-sdk-go:feat/ecHeader_parentSplit into master 2024-05-20 09:53:37 +00:00
Conversation 0 Commits 3 Files Changed 8
aarifullin commented 2024-05-14 12:11:48 +00:00
Collaborator
  • go.mod: Update frostfs-api-go/v2 version;
  • Introduce ec_parent search filter;
  • Introduce parentSplitID, parentSplitParentID fields for ECHeader;
  • Fix ECHeader's constructor;
  • Fix Split and Reconstruct;
  • Add unit-tests.
* go.mod: Update frostfs-api-go/v2 version; * Introduce `ec_parent` search filter; * Introduce `parentSplitID`, `parentSplitParentID` fields for `ECHeader`; * Fix ECHeader's constructor; * Fix `Split` and `Reconstruct`; * Add unit-tests.
aarifullin added 3 commits 2024-05-14 12:11:51 +00:00
edd2cfbc39 [#XX] go.mod: Update frostfs-api-go/v2 version 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
59f52f3b04 [#XX] object: Introduce `ec_parent` search filter 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
DCO / DCO (pull_request) Failing after 1m9s Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m17s Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m28s Details
Tests and linters / Lint (pull_request) Successful in 3m3s Details
6d43e166ed [#XX] object: Introduce new fields for `ECHeader` 
* Add `parentSplitID`, `parentSplitIndex` and setters/getters
  for them;
* Fix `NewECHeader` constructor;
* Add unit-test for Split with ec-parents case.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
aarifullin force-pushed feat/ecHeader_parentSplit from 6d43e166ed to 3c78222892 2024-05-14 12:12:33 +00:00 Compare
aarifullin requested review from fyrchik 2024-05-14 12:12:37 +00:00
aarifullin requested review from storage-core-committers 2024-05-14 12:12:38 +00:00
aarifullin requested review from storage-core-developers 2024-05-14 12:12:46 +00:00
aarifullin reviewed 2024-05-14 12:14:27 +00:00
object/erasurecode/split.go Outdated
@ -27,0 +32,4 @@
chld := obj.Parent().Children()
for i := range chld {
if chld[i].Equals(objID) {
parentSplitIndex = uint32(i)
aarifullin commented 2024-05-14 12:14:26 +00:00
Poster
Collaborator

@fyrchik, please, could you fix me if this is an incorrect way to define the index within big Split?

@fyrchik, please, could you fix me if this is an incorrect way to define the index within *big* Split?
fyrchik commented 2024-05-14 12:53:08 +00:00
Owner

These Children are not always present (because when we cut 2nd child we do not now how much more to expect).
I believe the only way to do this is to accept an explicit parameter in Split

These `Children` are not always present (because when we cut 2nd child we do not now how much more to expect). I believe the only way to do this is to accept an explicit parameter in `Split`
fyrchik commented 2024-05-14 12:53:51 +00:00
Owner

Maybe even another public function for this which reuses most of the code, so that we have a simple interface for small objects.

Maybe even another public function for this which reuses most of the code, so that we have a simple interface for small objects.
fyrchik commented 2024-05-14 12:53:53 +00:00
Owner

Maybe even another public function for this which reuses most of the code, so that we have a simple interface for small objects.

Maybe even another public function for this which reuses most of the code, so that we have a simple interface for small objects.
aarifullin force-pushed feat/ecHeader_parentSplit from 3c78222892 to 8ccb0451be 2024-05-15 08:22:14 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from 8ccb0451be to a4e80d3f6c 2024-05-15 08:32:48 +00:00 Compare
acid-ant reviewed 2024-05-15 12:52:46 +00:00
client/apemanager_add_chain.go Outdated
@ -0,0 +4,4 @@
"context"
"fmt"
apemanager_v2 "git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/apemanager"
acid-ant commented 2024-05-15 12:52:46 +00:00
Collaborator

In other places we are following LowerCamelCase convention.

In other places we are following LowerCamelCase convention.
👍 1
aarifullin commented 2024-05-17 12:20:53 +00:00
Poster
Collaborator

This commit with these changes has been picked accidentally :) I've removed it

This commit with these changes has been picked accidentally :) I've removed it
aarifullin changed title from object: Introduce new fields for `ECHeader` type to WIP: object: Introduce new fields for `ECHeader` type 2024-05-16 09:07:11 +00:00
aarifullin force-pushed feat/ecHeader_parentSplit from a4e80d3f6c to 3d9313b323 2024-05-16 09:26:17 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from 3d9313b323 to 729641b285 2024-05-16 09:30:57 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from 729641b285 to 340c72526d 2024-05-16 11:41:06 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from 340c72526d to ee00a4da10 2024-05-16 11:46:57 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from ee00a4da10 to facf1f2a1e 2024-05-16 11:52:32 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from facf1f2a1e to ea4585bea8 2024-05-16 12:17:40 +00:00 Compare
aarifullin force-pushed feat/ecHeader_parentSplit from ea4585bea8 to 3de256d05e 2024-05-17 12:18:14 +00:00 Compare
aarifullin changed title from WIP: object: Introduce new fields for `ECHeader` type to object: Introduce new fields for `ECHeader` type 2024-05-17 12:21:02 +00:00
fyrchik approved these changes 2024-05-17 13:18:05 +00:00
client/apemanager_remove_chain.go Outdated
@ -0,0 +9,4 @@
"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/rpc/client"
session_v2 "git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/session"
"git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/signature"
apemanager_sdk "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/apemanager"
fyrchik commented 2024-05-16 08:08:35 +00:00
Owner

I believe sdk packages can use default names.

I believe sdk packages can use default names.
fyrchik marked this conversation as resolved
object/erasure_code.go Outdated
@ -17,1 +13,3 @@
headerLength uint32
parent oid.ID
parentSplitID *SplitID
parentSplitIndexSet bool
fyrchik commented 2024-05-16 08:18:30 +00:00
Owner

There should not be such variable: we always treat missing numbers as 0 in API and 0 also makes sense for small objects -- which are like big ones, but with only 1 part.

There should not be such variable: we always treat missing numbers as 0 in API and 0 also makes sense for small objects -- which are like big ones, but with only 1 part.
fyrchik marked this conversation as resolved
achuprov approved these changes 2024-05-20 09:36:17 +00:00
fyrchik merged commit 3de256d05e into master 2024-05-20 09:53:37 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
achuprov
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#223
There is no content yet.
Delete Branch "aarifullin/frostfs-sdk-go:feat/ecHeader_parentSplit"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?