TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

Introduce APEOverride for Bearer-token #225

Merged
fyrchik merged 2 commits from aarifullin/frostfs-sdk-go:feat/beartoken_ape into master 2024-05-31 12:14:44 +00:00
Conversation 0 Commits 2 Files changed 12 +245 -70
aarifullin commented 2024-05-30 08:29:56 +00:00
Member
Copy link
  • Update go.mod;
  • Resolve conflicts for packages;
  • Fix client's apemanager methods.
  • Move apemanager to ape
  • Introduce APEOverride for Bearer-token
* Update go.mod; * Resolve conflicts for packages; * Fix client's `apemanager` methods. * Move `apemanager` to `ape` * Introduce `APEOverride` for `Bearer`-token
aarifullin force-pushed feat/beartoken_ape from ecf35f020f to ef886376f6 2024-05-30 08:30:48 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-05-30 08:31:01 +00:00
aarifullin requested review from storage-core-developers 2024-05-30 08:31:41 +00:00
aarifullin requested review from storage-services-committers 2024-05-30 08:32:01 +00:00
aarifullin requested review from storage-services-developers 2024-05-30 08:32:02 +00:00
aarifullin force-pushed feat/beartoken_ape from ef886376f6 to e28536b81b 2024-05-30 08:45:29 +00:00 Compare
aarifullin force-pushed feat/beartoken_ape from e28536b81b to 0082f1f132 2024-05-30 08:50:18 +00:00 Compare
aarifullin force-pushed feat/beartoken_ape from 0082f1f132 to b08e5ad989 2024-05-30 08:58:10 +00:00 Compare
fyrchik approved these changes 2024-05-30 15:30:22 +00:00
bearer/bearer_test.go Outdated
@ -84,0 +139,4 @@
}
for i := range lhs.GetChains() {
if !reflect.DeepEqual(lhs.GetChains()[i], rhs.GetChains()[i]) {
fyrchik commented 2024-05-30 15:29:28 +00:00
Owner
Copy link

If we already use deep equal, why not use it on lhs and rhs?

If we already use deep equal, why not use it on `lhs` and `rhs`?
aarifullin commented 2024-05-30 15:37:10 +00:00
Author
Member
Copy link

Sorry, this is the flavor of the previous implementation. Fixed

Sorry, this is the flavor of the previous implementation. Fixed
fyrchik marked this conversation as resolved
aarifullin force-pushed feat/beartoken_ape from b08e5ad989 to 4f5bad8367 2024-05-30 15:35:59 +00:00 Compare
fyrchik approved these changes 2024-05-30 18:20:58 +00:00
acid-ant approved these changes 2024-05-31 07:40:37 +00:00
dkirillov reviewed 2024-05-31 09:59:27 +00:00
bearer/bearer.go Outdated
@ -39,0 +106,4 @@
apeOverride.SetTarget(c.Target.ToV2())
chains := make([]*apeV2.Chain, len(c.Chains))
for i := range c.Chains {
chains[i] = new(apeV2.Chain)
dkirillov commented 2024-05-31 09:51:12 +00:00
Member
Copy link

It seems this is unnecessary because of the next line

It seems this is unnecessary because of the next line
👍 1
aarifullin commented 2024-05-31 11:23:56 +00:00
Author
Member
Copy link

True. Fixed

True. Fixed
dkirillov marked this conversation as resolved
bearer/bearer.go Outdated
@ -72,6 +151,16 @@ func (b *Token) readFromV2(m acl.BearerToken, checkFieldPresence bool) error {
return errors.New("missing token lifetime")
}
b.apeOverride = nil
dkirillov commented 2024-05-31 09:59:16 +00:00
Member
Copy link

Why do we need this?
If we want make sure there is not old data then probably we need the same for other fields. Currently this isn't fully consistent I suppose

Why do we need this? If we want make sure there is not old data then probably we need the same for other fields. Currently this isn't fully consistent I suppose
aarifullin commented 2024-05-31 11:24:26 +00:00
Author
Member
Copy link

Okay, I remate in old manner with flag and made consistent with other fields

Okay, I remate in old manner with flag and made consistent with other fields
dkirillov marked this conversation as resolved
bearer/bearer.go Outdated
@ -217,0 +314,4 @@
b.apeOverride = v
}
func (b *Token) APEOverride() *APEOverride {
dkirillov commented 2024-05-31 09:43:59 +00:00
Member
Copy link

Do we need comment for this method?

Do we need comment for this method?
aarifullin commented 2024-05-31 11:25:34 +00:00
Author
Member
Copy link

Added

Added
dkirillov marked this conversation as resolved
aarifullin force-pushed feat/beartoken_ape from 4f5bad8367 to 7596f110da 2024-05-31 11:23:22 +00:00 Compare
aarifullin requested review from acid-ant 2024-05-31 11:25:38 +00:00
aarifullin requested review from fyrchik 2024-05-31 11:25:39 +00:00
dkirillov approved these changes 2024-05-31 11:38:27 +00:00
fyrchik merged commit 717a7d00ef into master 2024-05-31 12:14:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
fyrchik
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#225
No description provided.
Delete branch "aarifullin/frostfs-sdk-go:feat/beartoken_ape"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?