TrueCloudLab/frostfs-sdk-go
30
0
Fork 20
Code Issues 29 Pull requests 1 Releases Activity Actions

bearer: Add method IsSetAPEOverride #227

Closed
acid-ant wants to merge 1 commit from acid-ant/frostfs-sdk-go:feature/token-bearer into master
pull from: acid-ant/frostfs-sdk-go:feature/token-bearer
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +7
acid-ant commented 2024-06-04 07:49:10 +00:00
Member
Copy link

Signed-off-by: Anton Nikiforov an.nikiforov@yadro.com

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
acid-ant force-pushed feature/token-bearer from 21f327e8dc to 2a04a40710 2024-06-04 07:54:37 +00:00 Compare
acid-ant requested review from storage-core-committers 2024-06-04 08:00:47 +00:00
acid-ant requested review from storage-core-developers 2024-06-04 08:00:48 +00:00
acid-ant changed title from WIP: bearer: Add method `IsSetAPEOverride` to bearer: Add method `IsSetAPEOverride` 2024-06-04 08:01:01 +00:00
fyrchik reviewed 2024-06-04 08:01:15 +00:00
bearer/bearer.go
@ -316,0 +316,4 @@
// IsSetAPEOverride return true if APEOverride is set.
//
// See also: APEOverride.
func (b *Token) IsSetAPEOverride() bool {
fyrchik commented 2024-06-04 08:01:15 +00:00
Owner
Copy link

Why do we need this? Empty table is valid because it is not an optional parameter.

Why do we need this? Empty table is valid because it is not an optional parameter.
acid-ant commented 2024-06-04 08:07:45 +00:00
Author
Member
Copy link

To quickly check that table is empty, to avoid checking equality to empty.

To quickly check that table is empty, to avoid checking equality to empty.
fyrchik commented 2024-06-04 09:58:46 +00:00
Owner
Copy link

I mean, when it is missing, we can assume it is present and is empty.

I mean, when it is missing, we can assume it is present and is empty.
dstepanov-yadro approved these changes 2024-06-04 08:18:59 +00:00
achuprov approved these changes 2024-06-04 08:34:32 +00:00
acid-ant closed this pull request 2024-06-04 11:56:32 +00:00
All checks were successful
DCO / DCO (pull_request) Successful in 1m6s
Details
Tests and linters / Tests (1.21) (pull_request) Successful in 1m21s
Details
Tests and linters / Tests (1.20) (pull_request) Successful in 1m30s
Details
Tests and linters / Lint (pull_request) Successful in 2m11s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
achuprov
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#227
No description provided.
Delete branch "acid-ant/frostfs-sdk-go:feature/token-bearer"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?