TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

Add pre-commit framework #23

Merged
fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:add-pre-commit into master 2023-07-26 21:08:02 +00:00
Conversation 0 Commits 1 Files changed 2 +16
fyrchik commented 2023-03-07 06:45:53 +00:00
Owner
Copy link
No description provided.
fyrchik requested review from storage-core-committers 2023-03-07 06:46:01 +00:00
fyrchik requested review from storage-core-developers 2023-03-07 06:46:01 +00:00
fyrchik force-pushed add-pre-commit from d8b5c16278 to 626da330d0 2023-03-07 06:46:21 +00:00 Compare
carpawell approved these changes 2023-03-09 16:55:25 +00:00
pool/pool.go Outdated
@ -1664,6 +1664,7 @@ func (p *Pool) log(level zapcore.Level, msg string, fields ...zap.Field) {
return
}
//nolint:exhaustive
carpawell commented 2023-03-09 16:55:22 +00:00
Contributor
Copy link

why not fix that?

why not fix that?
fyrchik commented 2023-03-09 19:52:24 +00:00
Author
Owner
Copy link

A matter of taste, but default indeed could look better.

A matter of taste, but `default` indeed could look better.
fyrchik commented 2023-03-09 19:53:45 +00:00
Author
Owner
Copy link

It was already fixed in master another way.

It was already fixed in master another way.
fyrchik force-pushed add-pre-commit from 626da330d0 to 0e1999c965 2023-03-09 19:53:55 +00:00 Compare
fyrchik merged commit 0e1999c965 into master 2023-03-09 19:54:16 +00:00
fyrchik referenced this pull request from a commit 2023-03-09 19:54:16 +00:00
[#23] pre-commit: Add gitlint hook
fyrchik deleted branch add-pre-commit 2023-03-09 19:54:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
carpawell
TrueCloudLab/storage-core-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#23
No description provided.
Delete branch "fyrchik/frostfs-sdk-go:add-pre-commit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?