Make naming more consistent #230

New Issue

Open

opened 2024-06-24 06:28:43 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-06-24 06:28:43 +00:00

Owner

API has LocalNodeInfo method, but we have EndpointInfo. Suggest renaming to map API name.
For streaming RPC we have *Init suffix in method names, because they return a handle which require further processing. However, parameter names do not always have this suffix. I suggest unify naming across such methods. IMO methods should retain Init suffix and parameters should not (discussable).

1. API has `LocalNodeInfo` [method](https://git.frostfs.info/TrueCloudLab/frostfs-api/src/commit/0916cb5398dc06b0f229bf36170582e7d7038438/netmap/service.proto#L28), but we have `EndpointInfo`. Suggest renaming to map API name. 2. For streaming RPC we have `*Init` suffix in method names, because they return a handle which require further processing. However, parameter names do not always have this suffix. I suggest unify naming across such methods. IMO methods should retain `Init` suffix and parameters should not (discussable).