TrueCloudLab
/
frostfs-sdk-go
29
0
Fork 20
Code Issues 31 Pull Requests 2 Actions Releases Activity

pool: Introduce ape-manager methods #233

Merged
fyrchik merged 1 commits from aarifullin/frostfs-sdk-go:feat/pool_apemngr into master 2024-07-04 12:04:38 +00:00
Conversation 0 Commits 1 Files Changed 2
aarifullin commented 2024-07-03 14:24:24 +00:00
Collaborator
  • Remove GetEACL, SetEACL methods as they are deprecated;
  • Fix mock;
  • Introduce add/remove/list methods to request ape-manager for the client.
* Remove GetEACL, SetEACL methods as they are deprecated; * Fix mock; * Introduce add/remove/list methods to request ape-manager for the client.
aarifullin force-pushed feat/pool_apemngr from 4b79b2a844 to cba8cf7810 2024-07-03 14:27:08 +00:00 Compare
aarifullin requested review from storage-core-committers 2024-07-03 14:28:20 +00:00
aarifullin requested review from storage-core-developers 2024-07-03 14:28:40 +00:00
aarifullin requested review from storage-services-committers 2024-07-03 14:29:07 +00:00
aarifullin requested review from storage-services-developers 2024-07-03 14:29:18 +00:00
aarifullin force-pushed feat/pool_apemngr from cba8cf7810 to 25e00f0b9d 2024-07-03 14:34:06 +00:00 Compare
acid-ant requested changes 2024-07-03 14:44:17 +00:00
pool/pool.go Outdated
@ -596,4 +585,1 @@
return res.Table(), nil
}
// containerSetEACL invokes sdkClient.ContainerSetEACL parse response status to error.
acid-ant commented 2024-07-03 14:43:56 +00:00
Collaborator

Doc needs to be updated here and below.

Doc needs to be updated here and below.
aarifullin commented 2024-07-03 15:59:02 +00:00
Poster
Collaborator

Oh, my bad. Fixed!

Oh, my bad. Fixed!
aarifullin force-pushed feat/pool_apemngr from 25e00f0b9d to c57a4e13f2 2024-07-03 15:58:20 +00:00 Compare
aarifullin force-pushed feat/pool_apemngr from c57a4e13f2 to 6f9ca155f9 2024-07-03 22:27:47 +00:00 Compare
aarifullin force-pushed feat/pool_apemngr from 6f9ca155f9 to 27e965007d 2024-07-03 22:29:53 +00:00 Compare
fyrchik approved these changes 2024-07-04 06:03:43 +00:00
acid-ant approved these changes 2024-07-04 06:17:20 +00:00
achuprov approved these changes 2024-07-04 07:12:32 +00:00
dkirillov reviewed 2024-07-04 08:56:25 +00:00
pool/pool.go
@ -171,1 +178,4 @@
methodSessionCreate
methodAPEManagerAddChain
methodAPEManagerRemoveChain
methodAPEManagerListChains
dkirillov commented 2024-07-04 08:56:25 +00:00
Collaborator

Please add these method in NodeStatistics too https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/branch/master/pool/statistic.go

Please add these method in NodeStatistics too https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/branch/master/pool/statistic.go
fyrchik commented 2024-07-04 12:04:33 +00:00
Owner

FYI @aarifullin , please make a separate PR, want to merge this now

FYI @aarifullin , please make a separate PR, want to merge this now
fyrchik merged commit 27e965007d into master 2024-07-04 12:04:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
acid-ant
achuprov
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#233
There is no content yet.
Delete Branch "aarifullin/frostfs-sdk-go:feat/pool_apemngr"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?