TrueCloudLab/frostfs-sdk-go
29
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

pool: Update token expiration check in cache #234

Merged
alexvanin merged 1 commit from mbiryukova/frostfs-sdk-go:bugfix/token_expiration into master 2024-07-08 08:56:04 +00:00
Conversation 0 Commits 1 Files changed 4 +19 -10
mbiryukova commented 2024-07-05 09:35:52 +00:00
Member
Copy link

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-07-05 09:35:52 +00:00
mbiryukova force-pushed bugfix/token_expiration from 7714c7fdf8 to 560cbbd1f1 2024-07-05 09:36:38 +00:00 Compare
mbiryukova requested review from storage-core-committers 2024-07-05 09:45:44 +00:00
mbiryukova requested review from storage-core-developers 2024-07-05 09:45:45 +00:00
mbiryukova requested review from storage-sdk-committers 2024-07-05 09:45:45 +00:00
mbiryukova requested review from storage-sdk-developers 2024-07-05 09:45:47 +00:00
mbiryukova requested review from storage-services-committers 2024-07-05 09:45:49 +00:00
mbiryukova requested review from storage-services-developers 2024-07-05 09:45:52 +00:00
dstepanov-yadro reviewed 2024-07-05 10:42:05 +00:00
pool/cache.go
@ -68,3 +69,2 @@
epoch := c.currentEpoch.Load()
// use epoch+1 (clear cache beforehand) to prevent 'expired session token' error right after epoch tick
return val.token.ExpiredAt(epoch + 1)
preExpiredDur := c.tokenDuration / 2
dstepanov-yadro commented 2024-07-05 10:42:05 +00:00
Member
Copy link

I don't understand. If the lifetime of the session token in the cache is 10 epochs, then why will it be removed from the cache at epoch 95, and not 100?

I don't understand. If the lifetime of the session token in the cache is 10 epochs, then why will it be removed from the cache at epoch 95, and not 100?
mbiryukova commented 2024-07-05 12:57:54 +00:00
Author
Member
Copy link

To avoid errors if epoch increases between sending request to storage and its processing (which can occur now)
cc @alexvanin

To avoid errors if epoch increases between sending request to storage and its processing (which can occur now) cc @alexvanin
dkirillov approved these changes 2024-07-05 12:01:27 +00:00
fyrchik approved these changes 2024-07-05 14:04:04 +00:00
acid-ant approved these changes 2024-07-08 08:45:47 +00:00
alexvanin approved these changes 2024-07-08 08:55:23 +00:00
alexvanin merged commit 560cbbd1f1 into master 2024-07-08 08:56:04 +00:00
alexvanin deleted branch bugfix/token_expiration 2024-07-08 08:56:59 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dkirillov
fyrchik
acid-ant
alexvanin
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-sdk-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#234
No description provided.
Delete branch "mbiryukova/frostfs-sdk-go:bugfix/token_expiration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?