TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 33 Pull requests 3 Releases Activity Actions

[#276] Merge repo with frostfs-api-go #281

Merged
pogpp merged 1 commit from pogpp/frostfs-sdk-go:feature/276_merge_repos into master 2024-10-29 07:01:54 +00:00
Conversation 7 Commits 1 Files changed 337 +28244 -279
pogpp commented 2024-10-07 14:31:49 +00:00
Member
Copy link

Signed-off-by: Pavel Pogodaev p.pogodaev@yadro.com

Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp added 1 commit 2024-10-07 14:31:50 +00:00
[] Merge repo with frostfs-api-go
Some checks failed
/ DCO (pull_request) Failing after 14s
Details
/ Lint (pull_request) Failing after 1m23s
Details
/ Tests (pull_request) Failing after 29s
Details
7ef502e2c0 
Signed-off-by: Pavel Pogodaev <p.pogodaev@yadro.com>
pogpp changed title from [#276] Merge repo with frostfs-api-go to WIP: [#276] Merge repo with frostfs-api-go 2024-10-07 14:32:17 +00:00
pogpp requested review from alexvanin 2024-10-07 14:32:28 +00:00
pogpp requested review from orikik 2024-10-07 14:32:47 +00:00
pogpp requested review from fyrchik 2024-10-07 14:33:06 +00:00
pogpp requested review from dstepanov-yadro 2024-10-07 14:33:06 +00:00
pogpp commented 2024-10-07 14:33:56 +00:00
Author
Member
Copy link

As i understand - we are not supporting in SDK UsedSpaceAnnouncement ?

git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container

container/size.go:18:14: undefined: container.UsedSpaceAnnouncement
container/size.go:25:49: undefined: container.UsedSpaceAnnouncement
container/size.go:47:48: undefined: container.UsedSpaceAnnouncement

As i understand - we are not supporting in SDK UsedSpaceAnnouncement ? # git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container container/size.go:18:14: undefined: container.UsedSpaceAnnouncement container/size.go:25:49: undefined: container.UsedSpaceAnnouncement container/size.go:47:48: undefined: container.UsedSpaceAnnouncement
dstepanov-yadro commented 2024-10-07 14:53:26 +00:00
Member
Copy link

As i understand - we are not supporting in SDK UsedSpaceAnnouncement ?

git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container

container/size.go:18:14: undefined: container.UsedSpaceAnnouncement
container/size.go:25:49: undefined: container.UsedSpaceAnnouncement
container/size.go:47:48: undefined: container.UsedSpaceAnnouncement

Are you sure you've used the latest versions of sdk-go and api-go?

> As i understand - we are not supporting in SDK UsedSpaceAnnouncement ? > > # git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container > container/size.go:18:14: undefined: container.UsedSpaceAnnouncement > container/size.go:25:49: undefined: container.UsedSpaceAnnouncement > container/size.go:47:48: undefined: container.UsedSpaceAnnouncement Are you sure you've used the latest versions of `sdk-go` and `api-go`?
dstepanov-yadro requested changes 2024-10-07 14:54:00 +00:00
Dismissed
accounting/decimal.go Outdated
@ -1,10 +1,10 @@
package accounting
import "git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/accounting"
import "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/apiv2/accounting"
dstepanov-yadro commented 2024-10-07 14:51:27 +00:00
Member
Copy link

apiv2 -> api
v2 is just go.mod suffix, no need to add it to sdk-go

`apiv2` -> `api` v2 is just go.mod suffix, no need to add it to `sdk-go`
👍 1
pogpp force-pushed feature/276_merge_repos from 7ef502e2c0 to 397123a810 2024-10-08 10:35:16 +00:00 Compare
pogpp force-pushed feature/276_merge_repos from 397123a810 to 712b50522b 2024-10-08 11:05:05 +00:00 Compare
pogpp force-pushed feature/276_merge_repos from 712b50522b to 349d6b6140 2024-10-08 11:45:49 +00:00 Compare
pogpp force-pushed feature/276_merge_repos from 349d6b6140 to d404a1026e 2024-10-08 11:48:03 +00:00 Compare
pogpp force-pushed feature/276_merge_repos from d404a1026e to 6693b47366 2024-10-08 11:53:52 +00:00 Compare
pogpp commented 2024-10-08 13:57:31 +00:00
Author
Member
Copy link

Last thing to fix.
Error Trace: /home/paul/GolandProjects/frostfs-sdk-go/object/raw_test.go:306 Error: Not equal: expected: &object.Object{objectID:(*refs.ObjectID)(0xc00011e858), idSig:(*refs.Signature)(nil), header:(*object.Header)(0xc0001e2540), payload:[]uint8(nil), marshalData:[]uint8(nil)} actual : &object.Object{objectID:(*refs.ObjectID)(0xc00011e930), idSig:(*refs.Signature)(nil), header:(*object.Header)(0xc0001e2bd0), payload:[]uint8{}, marshalData:[]uint8(nil)}

Old test - simple as it can be.
But I can't find the root cause of diff payload:[]uint8{} and payload:[]uint8(nil)

Last thing to fix. ` Error Trace: /home/paul/GolandProjects/frostfs-sdk-go/object/raw_test.go:306 Error: Not equal: expected: &object.Object{objectID:(*refs.ObjectID)(0xc00011e858), idSig:(*refs.Signature)(nil), header:(*object.Header)(0xc0001e2540), payload:[]uint8(nil), marshalData:[]uint8(nil)} actual : &object.Object{objectID:(*refs.ObjectID)(0xc00011e930), idSig:(*refs.Signature)(nil), header:(*object.Header)(0xc0001e2bd0), payload:[]uint8{}, marshalData:[]uint8(nil)}` Old test - simple as it can be. But I can't find the root cause of diff `payload:[]uint8{}` and ` payload:[]uint8(nil)`
pogpp requested review from dstepanov-yadro 2024-10-09 13:08:27 +00:00
pogpp commented 2024-10-11 07:05:57 +00:00
Author
Member
Copy link

So, test failed after this commit here

So, test failed after this commit [here](https://git.frostfs.info/TrueCloudLab/frostfs-api-go/commit/29c522d5d8a31721b32fa0932f2f4abba445ec77)
pogpp force-pushed feature/276_merge_repos from 6693b47366 to 2156a6bf73 2024-10-11 20:19:29 +00:00 Compare
pogpp force-pushed feature/276_merge_repos from 2156a6bf73 to 12ef42f496 2024-10-12 09:16:50 +00:00 Compare
pogpp force-pushed feature/276_merge_repos from 12ef42f496 to 7d6ce3928b 2024-10-12 09:48:49 +00:00 Compare
pogpp changed title from WIP: [#276] Merge repo with frostfs-api-go to [#276] Merge repo with frostfs-api-go 2024-10-12 09:49:17 +00:00
dstepanov-yadro commented 2024-10-14 15:13:39 +00:00
Member
Copy link

As i understand - we are not supporting in SDK UsedSpaceAnnouncement ?

git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container

container/size.go:18:14: undefined: container.UsedSpaceAnnouncement
container/size.go:25:49: undefined: container.UsedSpaceAnnouncement
container/size.go:47:48: undefined: container.UsedSpaceAnnouncement

Are you sure you've used the latest versions of sdk-go and api-go?

@pogpp please check this. I don't see container.UsedSpaceAnnouncement in the latest versions of SDK and API-Go

> > As i understand - we are not supporting in SDK UsedSpaceAnnouncement ? > > > > # git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container > > container/size.go:18:14: undefined: container.UsedSpaceAnnouncement > > container/size.go:25:49: undefined: container.UsedSpaceAnnouncement > > container/size.go:47:48: undefined: container.UsedSpaceAnnouncement > > Are you sure you've used the latest versions of `sdk-go` and `api-go`? @pogpp please check this. I don't see `container.UsedSpaceAnnouncement` in the latest versions of SDK and API-Go
pogpp commented 2024-10-16 08:10:33 +00:00
Author
Member
Copy link

As i understand - we are not supporting in SDK UsedSpaceAnnouncement ?

git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container

container/size.go:18:14: undefined: container.UsedSpaceAnnouncement
container/size.go:25:49: undefined: container.UsedSpaceAnnouncement
container/size.go:47:48: undefined: container.UsedSpaceAnnouncement

Are you sure you've used the latest versions of sdk-go and api-go?

@pogpp please check this. I don't see container.UsedSpaceAnnouncement in the latest versions of SDK and API-Go

Yep, my fault. Updated to actual versions

> > > As i understand - we are not supporting in SDK UsedSpaceAnnouncement ? > > > > > > # git.frostfs.info/TrueCloudLab/frostfs-sdk-go/container > > > container/size.go:18:14: undefined: container.UsedSpaceAnnouncement > > > container/size.go:25:49: undefined: container.UsedSpaceAnnouncement > > > container/size.go:47:48: undefined: container.UsedSpaceAnnouncement > > > > Are you sure you've used the latest versions of `sdk-go` and `api-go`? > > @pogpp please check this. I don't see `container.UsedSpaceAnnouncement` in the latest versions of SDK and API-Go Yep, my fault. Updated to actual versions
dstepanov-yadro approved these changes 2024-10-17 07:18:22 +00:00
Dismissed
dstepanov-yadro approved these changes 2024-10-17 07:28:14 +00:00
Dismissed
acid-ant commented 2024-10-17 07:34:24 +00:00
Member
Copy link

Please update .gitattributes accordingly.
Can you also please exclude go.sum via /go.sum -diff?

Please update `.gitattributes` accordingly. Can you also please exclude `go.sum` via `/go.sum -diff`?
👍 1
pogpp force-pushed feature/276_merge_repos from 7d6ce3928b to 410dcf5fae 2024-10-17 09:07:23 +00:00 Compare
pogpp dismissed dstepanov-yadro's review 2024-10-17 09:07:23 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

acid-ant approved these changes 2024-10-17 13:11:48 +00:00
Dismissed
pogpp force-pushed feature/276_merge_repos from 410dcf5fae to e6f438bce4 2024-10-17 14:07:19 +00:00 Compare
pogpp requested review from dstepanov-yadro 2024-10-17 14:10:11 +00:00
dstepanov-yadro approved these changes 2024-10-21 14:21:47 +00:00
Dismissed
alexvanin approved these changes 2024-10-22 08:28:26 +00:00
Dismissed
Makefile Outdated
@ -15,0 +47,4 @@
# Regenerate code for proto files
protoc:
alexvanin commented 2024-10-22 08:28:24 +00:00
Owner
Copy link

Seems like this target depends on bin/protogen, maybe it will be nice to put it into part of protoc-install or make a dependency for this target.

Seems like this target depends on `bin/protogen`, maybe it will be nice to put it into part of `protoc-install` or make a dependency for this target.
orikik approved these changes 2024-10-22 08:52:23 +00:00
Dismissed
fyrchik reviewed 2024-10-22 12:11:41 +00:00
ape/chain.go Outdated
@ -5,3 +5,3 @@
"fmt"
apeV2 "git.frostfs.info/TrueCloudLab/frostfs-api-go/v2/ape"
apeV2 "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/api/ape"
fyrchik commented 2024-10-22 12:11:41 +00:00
Owner
Copy link

Could you explain, where do we plan to land version here?
Will the import path change after we transition to v3?

Could you explain, where do we plan to land version here? Will the import path change after we transition to v3?
pogpp commented 2024-10-22 14:10:22 +00:00
Author
Member
Copy link

according to this comment i decided that we don't need it

according to [this](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/281#issuecomment-54036) comment i decided that we don't need it
pogpp force-pushed feature/276_merge_repos from e6f438bce4 to 6ce73790ea 2024-10-22 14:05:14 +00:00 Compare
pogpp dismissed acid-ant's review 2024-10-22 14:05:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pogpp dismissed dstepanov-yadro's review 2024-10-22 14:05:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pogpp dismissed alexvanin's review 2024-10-22 14:05:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

pogpp dismissed orikik's review 2024-10-22 14:05:15 +00:00
Reason:

New commits pushed, approval review dismissed automatically according to repository settings

orikik approved these changes 2024-10-24 09:43:31 +00:00
acid-ant approved these changes 2024-10-24 10:33:06 +00:00
alexvanin approved these changes 2024-10-25 09:19:18 +00:00
fyrchik approved these changes 2024-10-28 12:04:11 +00:00
pogpp merged commit 6ce73790ea into master 2024-10-29 07:01:54 +00:00
pogpp deleted branch feature/276_merge_repos 2024-10-29 07:01:57 +00:00
fyrchik referenced this pull request from a commit 2024-12-16 07:49:01 +00:00
[#315] api: Restore test.proto file
Sign in to join this conversation.
Reviewers
No reviewers
orikik
acid-ant
alexvanin
fyrchik
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
6 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#281
No description provided.
Delete branch "pogpp/frostfs-sdk-go:feature/276_merge_repos"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?