TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

[#279] pool: Count maintenance mode errors in object search #288

Merged
fyrchik merged 1 commit from mbiryukova/frostfs-sdk-go:bugfix/count_mm_errors into master 2024-10-22 12:41:12 +00:00
Conversation 0 Commits 1 Files changed 2 +12 -5
mbiryukova commented 2024-10-16 17:44:48 +00:00
Member
Copy link

Closes #279

Signed-off-by: Marina Biryukova m.biryukova@yadro.com

Closes #279 Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova self-assigned this 2024-10-16 17:44:48 +00:00
mbiryukova added 1 commit 2024-10-16 17:44:48 +00:00
[#279] pool: Count maintenance mode errors in object search
All checks were successful
DCO / DCO (pull_request) Successful in 58s
Details
Tests and linters / Tests (pull_request) Successful in 1m12s
Details
Tests and linters / Lint (pull_request) Successful in 1m47s
Details
8da1a69d2b 
Signed-off-by: Marina Biryukova <m.biryukova@yadro.com>
mbiryukova requested review from storage-core-committers 2024-10-16 17:47:12 +00:00
mbiryukova requested review from storage-core-developers 2024-10-16 17:47:12 +00:00
mbiryukova requested review from storage-sdk-committers 2024-10-16 17:47:13 +00:00
mbiryukova requested review from storage-sdk-developers 2024-10-16 17:47:14 +00:00
mbiryukova requested review from storage-services-committers 2024-10-16 17:47:15 +00:00
mbiryukova requested review from storage-services-developers 2024-10-16 17:47:15 +00:00
dkirillov reviewed 2024-10-17 06:48:41 +00:00
pool/pool.go Outdated
@ -2721,2 +2722,4 @@
}
switch err.(type) {
case *apistatus.NodeUnderMaintenance:
dkirillov commented 2024-10-17 06:48:40 +00:00
Member
Copy link

I would expect that we will use handleError here to handle all errors, not only maintenance

I would expect that we will use `handleError` here to handle all errors, not only maintenance
👍 1
fyrchik commented 2024-10-17 08:11:05 +00:00
Owner
Copy link

It looks very tricky, especially given that we return the error after that.
Can we handle it where Read is called?

It looks very tricky, especially given that we return the error after that. Can we handle it where `Read` is called?
mbiryukova commented 2024-10-17 10:40:07 +00:00
Author
Member
Copy link

But if I understand correctly, Read can be called outside pool, in which case we can't count this error

But if I understand correctly, `Read` can be called outside pool, in which case we can't count this error
👍 1
fyrchik marked this conversation as resolved
mbiryukova force-pushed bugfix/count_mm_errors from 8da1a69d2b to 5594551a52 2024-10-21 09:02:01 +00:00 Compare
fyrchik approved these changes 2024-10-21 10:13:31 +00:00
dkirillov approved these changes 2024-10-22 08:00:02 +00:00
dkirillov left a comment
Member
Copy link

LGTM
Is it possible to add some tests?

LGTM Is it possible to add some tests?
fyrchik merged commit 5361f0eceb into master 2024-10-22 12:41:12 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dkirillov
TrueCloudLab/storage-core-developers
TrueCloudLab/storage-sdk-developers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
mbiryukova
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#288
No description provided.
Delete branch "mbiryukova/frostfs-sdk-go:bugfix/count_mm_errors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?