TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 30 Pull requests 3 Releases Activity Actions

bugfix/278-pool_maintenance_rebalance #289

Merged
fyrchik merged 1 commit from dkirillov/frostfs-sdk-go:bugfix/278-pool_maintenance_rebalance into master 2024-10-22 12:26:12 +00:00
Conversation 0 Commits 1 Files changed 3 +301 -79
dkirillov commented 2024-10-17 13:27:30 +00:00
Member
Copy link

close #278

should be merged after #286

close #278 should be merged after #286
dkirillov self-assigned this 2024-10-17 13:27:30 +00:00
dkirillov added 3 commits 2024-10-17 13:27:30 +00:00 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
[#283] pool: Mark node unhealthy if node is under maintenance
All checks were successful
DCO / DCO (pull_request) Successful in 59s
Details
Tests and linters / Tests (pull_request) Successful in 1m13s
Details
Tests and linters / Lint (pull_request) Successful in 2m4s
Details
79f387317a 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
[#278] pool: Don't make maintenance node healthy in rebalance
All checks were successful
DCO / DCO (pull_request) Successful in 58s
Details
Tests and linters / Tests (pull_request) Successful in 1m14s
Details
Tests and linters / Lint (pull_request) Successful in 1m28s
Details
f88896874c 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
dkirillov requested review from storage-services-developers 2024-10-17 13:30:10 +00:00
dkirillov requested review from storage-sdk-developers 2024-10-17 13:30:11 +00:00
dkirillov requested review from storage-sdk-committers 2024-10-17 13:30:11 +00:00
dkirillov requested review from storage-services-committers 2024-10-17 13:30:13 +00:00
dkirillov force-pushed bugfix/278-pool_maintenance_rebalance from f88896874c to 05aa3becae 2024-10-17 13:31:57 +00:00 Compare
alexvanin reviewed 2024-10-18 13:08:30 +00:00
alexvanin reviewed 2024-10-18 13:12:07 +00:00
pool/pool.go
@ -2237,0 +2253,4 @@
if res, err := c.healthcheck(ctx); err == nil {
if res.Status().IsMaintenance() {
return wasHealthy, new(apistatus.NodeUnderMaintenance)
alexvanin commented 2024-10-18 13:12:07 +00:00
Owner
Copy link

It would be nice to explain why we don't restart when maintenance mode is returned. Maybe with the connection of #283

It would be nice to explain why we don't restart when maintenance mode is returned. Maybe with the connection of https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/283
dkirillov commented 2024-10-18 14:42:53 +00:00
Author
Member
Copy link

🤔 It seems quite obvious that node doesn't change its own status after client reconnect. No?

🤔 It seems quite obvious that node doesn't change its own status after client reconnect. No?
alexvanin commented 2024-10-18 14:47:48 +00:00
Owner
Copy link

If you put it that way, I think so...

If you put it that way, I think so...
alexvanin marked this conversation as resolved
alexvanin approved these changes 2024-10-18 13:25:16 +00:00
dkirillov requested review from alexvanin 2024-10-21 06:27:55 +00:00
dkirillov requested review from storage-services-committers 2024-10-21 06:28:13 +00:00
dkirillov requested review from storage-sdk-committers 2024-10-21 06:28:14 +00:00
dkirillov requested review from storage-core-committers 2024-10-21 06:28:27 +00:00
dkirillov requested review from storage-core-developers 2024-10-21 06:28:27 +00:00
aarifullin approved these changes 2024-10-22 12:11:03 +00:00
fyrchik merged commit 05aa3becae into master 2024-10-22 12:26:12 +00:00
dkirillov deleted branch bugfix/278-pool_maintenance_rebalance 2024-10-22 14:05:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
alexvanin
aarifullin
TrueCloudLab/storage-services-developers
TrueCloudLab/storage-sdk-developers
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-sdk-committers
TrueCloudLab/storage-core-committers
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
dkirillov
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#289
No description provided.
Delete branch "dkirillov/frostfs-sdk-go:bugfix/278-pool_maintenance_rebalance"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?