`user.ID.ScriptHash` should return no error #302

New issue

Closed

opened 2024-12-04 11:23:58 +00:00 by fyrchik · 0 comments

fyrchik commented

2024-12-04 11:23:58 +00:00

Owner

user.ID is a script hash and has 1-1 mapping to it (see #303)
The struct itself may have some of its internal invariants violated, but we already panic in the current code, and this seems right.
DecodeBytesBE returns nil error, because we check the lengths ourselves.
It's implementation may change in future, but I still think that the benefits of more succinct API are bigger, than downsides from ignoring an as-of-now-always-nil error.

`user.ID` _is_ a script hash and has 1-1 mapping to it (see #303) The struct itself may have some of its internal invariants violated, but we already panic in the current code, and this seems right. `DecodeBytesBE` returns nil error, because we check the lengths ourselves. It's implementation may change in future, but I still think that the benefits of more succinct API are bigger, than downsides from ignoring an as-of-now-always-nil error.