Should we add `node` address utils in SDK? #35

New issue

Open

opened 2023-03-08 23:37:53 +00:00 by snegurochka · 3 comments

snegurochka commented

2023-03-08 23:37:53 +00:00

Member

Original issue: https://github.com/nspcc-dev/neofs-sdk-go/issues/381

Like this:
d4b108d806/pkg/network/address.go

Original issue: https://github.com/nspcc-dev/neofs-sdk-go/issues/381 Like this: https://github.com/nspcc-dev/neofs-node/blob/d4b108d8065f8268a988cf3966e181f02e1e5af7/pkg/network/address.go

fyrchik added the

bug

label 2023-05-02 07:52:07 +00:00

fyrchik commented

2023-08-23 10:51:40 +00:00

Owner

I believe we should:

Arguably, the best thing for the client interface is a string, so we should parse different formats here.
It becomes possible to implement our custom netmap resolver and hide all the switching-between-same-node-endpoints complexity here (the address will probably parse some scheme).

I believe we should: 1. Arguably, the best thing for the client interface is a string, so we should parse different formats here. 2. It becomes possible to implement our custom netmap resolver and hide all the switching-between-same-node-endpoints complexity here (the address will probably parse some scheme).

fyrchik added the

good first issue

label 2023-08-23 10:51:45 +00:00

fyrchik referenced this issue

2024-12-16 12:08:06 +00:00

[#305] tree/pool: Add flag to use net map to prioritize tree services #305

fyrchik referenced this issue

2024-12-17 11:55:58 +00:00

[#305] tree/pool: Add flag to use net map to prioritize tree services #305

fyrchik commented

2025-03-17 11:59:15 +00:00

Owner

Closed via #305

fyrchik closed this issue

2025-03-17 11:59:17 +00:00

fyrchik added the

internal

label 2025-03-17 11:59:24 +00:00

fyrchik commented

2025-03-17 12:27:36 +00:00

Owner

I was to eager to close this, reopening:

Not all methods are ported (String() should be ported too).
FromString does a lot of conversions, let's profile and optimize the hell out of it.
Let's discuss whether to store .Sting() results in the struct itself, to avoid costly conversions.

I was to eager to close this, reopening: 1. Not all methods are ported (`String()` should be ported too). 2. `FromString` does a lot of conversions, let's profile and optimize the hell out of it. 3. Let's discuss whether to store `.Sting()` results in the struct itself, to avoid costly conversions.

fyrchik reopened this issue

2025-03-17 12:27:39 +00:00

fyrchik referenced this issue from TrueCloudLab/frostfs-node

2025-03-17 12:29:46 +00:00

Adopt address package from SDK #1681