api/netmap: Return a slice of parameters directly #354

Merged

fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:api-netmap-parameters into master

2025-04-07 14:39:47 +00:00

fyrchik commented

2025-04-05 05:38:05 +00:00

Owner

IterateParameters does a poor job:

it doesn't encapsulate well, because it returns a pointer,
it has a clunky interface, compared to range loop.

I have decided to return parameter slice and not iter.Seq for 2
reasons:

There already is SetParameters, so NetworkConfig struct is
expected to be modified.
This iterator uses pointers, so even with this interface the slice
can already be changed.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

`IterateParameters` does a poor job: - it doesn't encapsulate well, because it returns a pointer, - it has a clunky interface, compared to range loop. I have decided to return parameter slice and not `iter.Seq` for 2 reasons: 1. There already is `SetParameters`, so `NetworkConfig` struct is expected to be modified. 2. This iterator uses pointers, so even with this interface the slice can already be changed. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2025-04-05 05:38:05 +00:00

api/netmap: Return a slice of parameters directly

Code generation / Generate proto (pull_request) Successful in 34s

Details

Tests and linters / Lint (pull_request) Failing after 56s

Details

DCO / DCO (pull_request) Failing after 2m38s

Details

Tests and linters / Tests (pull_request) Successful in 3m42s

Details

f49bcefd8b

`IterateParameters` does a poor job:
- it doesn't encapsulate well, because it returns a pointer,
- it has a clunky interface, compared to range loop.

I have decided to return parameter slice and not `iter.Seq` for 2
reasons:
1. There already is `SetParameters`, so `NetworkConfig` struct is
   expected to be modified.
2. This iterator uses pointers, so even with this interface the slice
   can already be changed.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers

2025-04-05 05:38:05 +00:00

fyrchik force-pushed api-netmap-parameters from f49bcefd8b to 706ef9adf8

2025-04-05 05:38:23 +00:00

Compare

fyrchik force-pushed api-netmap-parameters from 706ef9adf8 to 61765f178c

2025-04-05 05:42:22 +00:00

Compare