TrueCloudLab/frostfs-sdk-go

Fork 21

Logs about used node in `Pool`'s errors #51

New issue

Open

opened 2023-04-13 10:59:56 +00:00 by carpawell · 5 comments

carpawell commented

2023-04-13 10:59:56 +00:00

Contributor

Currently, pool just returns an error with text message and without a node that returned that error.

I think it can:

Return node's endpoint via message;
Log errors with debug using internal logger;
...

Will simplify debug a little. E.g. in the morph multiclient I tried to log as much internal uncontrolable processes as I can.

@dkirillov, @alexvanin

Currently, pool just [returns](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/f41860f9bd41368d5ddedeb9ed535fcfe97c0fa3/pool/pool.go#L818) an error with text message and _without_ a node that returned that error. I think it can: 1. Return node's endpoint via message; 2. Log errors with `debug` using internal [logger](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/f41860f9bd41368d5ddedeb9ed535fcfe97c0fa3/pool/pool.go#L1563); 3. ... Will simplify debug a little. E.g. in the morph multiclient I tried to [log](https://git.frostfs.info/TrueCloudLab/frostfs-node/src/commit/01c0c90a869ef9f77ed412bd5a26c539579dacf7/pkg/morph/client/multi.go#L47-L58) as much internal uncontrolable processes as I can. @dkirillov, @alexvanin

👍 1

carpawell added the

question

label 2023-04-13 10:59:56 +00:00

fyrchik added the

pool

label 2023-05-02 07:56:56 +00:00

snegurochka added the

discussion

enhancement

labels 2023-05-03 17:15:15 +00:00

alexvanin self-assigned this 2023-06-01 06:50:53 +00:00

alexvanin removed their assignment 2023-06-01 06:51:01 +00:00

alexvanin self-assigned this 2023-06-01 06:51:08 +00:00

alexvanin commented

2023-06-01 06:51:32 +00:00

Owner

Let's go further and add a metric that returns current endpoint pool is talking to.

ironbee was assigned by alexvanin

2023-06-09 10:14:54 +00:00

alexvanin removed their assignment 2023-06-09 10:14:59 +00:00

dkirillov commented

2023-06-26 09:17:30 +00:00

Member

We should also pass logger to the wrapper:

prm.logger = params.logger

or add methods to set logger and use it

We should also pass logger to the [wrapper](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/aa8ffebc632840847215a39bfe69d64ad9571bf6/pool/pool.go#L1746): ``` prm.logger = params.logger ``` or add methods to set logger and use it

alexvanin commented

2023-07-26 15:50:56 +00:00

Owner

Summary:

issue is related for object pool, not tree pool,
in case of the error, pool should wrap endpoint address of the storage node before passing error to the caller,
add a metric to provide endpoint of current storage node which pool is connected to,
provide a way to pass logger to the wrapper.

Summary: - issue is related for _object_ pool, not _tree_ pool, - in case of the error, `pool` should wrap endpoint address of the storage node before passing error to the caller, - add a [metric](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/branch/master/pool/statistic.go) to provide endpoint of current storage node which `pool` is connected to, - provide a way to pass logger to the [wrapper](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/src/commit/aa8ffebc632840847215a39bfe69d64ad9571bf6/pool/pool.go#L1746).

anikeev-yadro commented

2023-08-08 13:28:04 +00:00

Member

From my POV we should have 2 metrics:

first for storage pool: show current healthy endpoints with the same priority
second for tree pool: current connected endpoint

From my POV we should have 2 metrics: - first for storage pool: show current healthy endpoints with the same priority - second for tree pool: current connected endpoint

ironbee referenced this issue from a pull request that will close it,

2023-08-11 11:00:51 +00:00

Add node addresses as debug information #147

fyrchik referenced this issue from a commit

2023-08-16 07:31:38 +00:00

[#51] Add current nodes as external statistics

fyrchik referenced this issue from a commit

2023-08-16 07:31:38 +00:00

[#51] Add node addresses as debug information

fyrchik closed this issue

2023-08-16 07:31:43 +00:00

alexvanin reopened this issue