TrueCloudLab
/
frostfs-sdk-go
29
0
Fork 18
Code Issues 29 Pull Requests 3 Actions Releases Activity

client: Simplify netmap/session methods #55

Merged
fyrchik merged 4 commits from fyrchik/frostfs-sdk-go:netmap-refactor into master 2023-04-18 09:58:35 +00:00
Conversation 0 Commits 4 Files Changed 9
fyrchik commented 2023-04-14 13:37:45 +00:00
Owner
There is no content yet.
fyrchik requested review from storage-core-committers 2023-04-14 13:37:50 +00:00
fyrchik requested review from storage-core-developers 2023-04-14 13:37:51 +00:00
fyrchik requested review from storage-services-committers 2023-04-14 13:37:58 +00:00
fyrchik requested review from storage-services-developers 2023-04-14 13:37:59 +00:00
ale64bit reviewed 2023-04-14 13:50:30 +00:00
client/netmap.go Outdated
@ -19,6 +19,16 @@ type PrmEndpointInfo struct {
prmCommonMeta
}
func (x *PrmEndpointInfo) formRequest(c *Client) (*v2netmap.LocalNodeInfoRequest, error) {
ale64bit commented 2023-04-14 13:50:30 +00:00
Collaborator

can we call it buildRequest, asRequest or simply request instead? Maybe I'm biased, but this sounds more like "requesting a form" than "forming a request" :)

can we call it `buildRequest`, `asRequest` or simply `request` instead? Maybe I'm biased, but this sounds more like "requesting a form" than "forming a request" :)
👍 3
aarifullin commented 2023-04-17 06:48:03 +00:00
Collaborator

or toRequest

or `toRequest`
fyrchik commented 2023-04-17 07:31:58 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:31:59 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:01 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:02 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:04 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:04 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:04 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:05 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:05 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:05 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:07 +00:00
Poster
Owner

Fixed

Fixed
fyrchik commented 2023-04-17 07:32:07 +00:00
Poster
Owner

Fixed

Fixed
aarifullin reviewed 2023-04-17 06:54:38 +00:00
client/netmap.go Outdated
@ -113,0 +92,4 @@
verV2 := body.GetVersion()
if verV2 == nil {
return &res, newErrMissingResponseField(fieldVersion)
aarifullin commented 2023-04-17 06:54:38 +00:00
Collaborator

I think it's more natural to return nil instead &res in the error case

I think it's more natural to return `nil` instead `&res` in the error case
fyrchik commented 2023-04-17 07:36:18 +00:00
Poster
Owner

Fixed. I don't really have arguments, besides returning status if we already have it. You suggestion is backwards compatible, however.

Fixed. I don't really have arguments, besides returning status if we already have it. You suggestion is backwards compatible, however.
fyrchik force-pushed netmap-refactor from 945ac2f58c to 3d2219e722 2023-04-17 07:31:51 +00:00 Compare
fyrchik force-pushed netmap-refactor from 3d2219e722 to 30121b9788 2023-04-17 07:35:21 +00:00 Compare
acid-ant approved these changes 2023-04-17 07:43:46 +00:00
dstepanov-yadro approved these changes 2023-04-17 07:52:44 +00:00
fyrchik merged commit cae2f37cdd into master 2023-04-18 09:58:35 +00:00
fyrchik deleted branch netmap-refactor 2023-04-18 09:58:35 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
acid-ant
dstepanov-yadro
TrueCloudLab/storage-services-committers
TrueCloudLab/storage-services-developers
Labels
Clear labels   
P0

Highest   
P1

High   
P2

Medium   
P3

Low   
good first issue

Good for newcomers   
pool

Tasks related to client pool
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff   
blocked

The issue or PR is blocked by something   
bug

Something is not working   
config

Configuration format update or breaking change   
discussion

Talking about something in order to reach a decision or to exchange ideas   
documentation

Documentation related   
duplicate

This issue or pull request already exists   
enhancement

New feature   
go

Language features adoption   
help wanted

Extra attention is needed   
internal
   
invalid

Something is wrong   
kludge

This is a kludge and we know it   
observability

Related to metrics, tracing and logs   
perfomance

Perfomance related   
question

More information is needed   
refactoring

Refactoring   
wontfix

This won't be fixed
No Label
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#55
There is no content yet.
Delete Branch "fyrchik/frostfs-sdk-go:netmap-refactor"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?