TrueCloudLab/frostfs-sdk-go
33
0
Fork 21
Code Issues 34 Pull requests 1 Releases Activity Actions

pool: Add copies number vector when putting object #57

Merged
fyrchik merged 1 commit from ironbee/frostfs-sdk-go:add_copies_number_vector into master 2023-04-20 12:30:00 +00:00
Conversation 0 Commits 1 Files changed 1 +8 -2
ironbee commented 2023-04-17 19:02:12 +00:00
Contributor
Copy link

Closes: #44

Signed-off-by: Artem Tataurov a.tataurov@yadro.com

Closes: #44 Signed-off-by: Artem Tataurov <a.tataurov@yadro.com>
ironbee requested review from carpawell 2023-04-17 19:02:23 +00:00
ironbee requested review from dkirillov 2023-04-17 19:02:31 +00:00
dkirillov reviewed 2023-04-18 06:35:48 +00:00
pool/pool.go Outdated
@ -1259,2 +1263,3 @@
copiesNumber uint32
copiesNumber uint32
copiesNumberVector []uint32
dkirillov commented 2023-04-18 06:35:48 +00:00
Member
Copy link

Actually, we can preserve only copiesNumberVector and make the follwoing changes

func (x *PrmObjectPut) SetCopiesNumber(copiesNumber uint32) {
	x.copiesNumberVector = []uint32{copiesNumber}
}

Also we should add new method to set vector:

func (x *PrmObjectPut) SetCopiesNumberVector(copiesNumber []uint32) {
	x.copiesNumberVector = copiesNumbers
}
Actually, we can preserve only `copiesNumberVector` and make the follwoing changes ``` func (x *PrmObjectPut) SetCopiesNumber(copiesNumber uint32) { x.copiesNumberVector = []uint32{copiesNumber} } ``` Also we should add new method to set vector: ``` func (x *PrmObjectPut) SetCopiesNumberVector(copiesNumber []uint32) { x.copiesNumberVector = copiesNumbers } ```
dkirillov marked this conversation as resolved
dkirillov reviewed 2023-04-18 06:36:55 +00:00
pool/pool.go Outdated
@ -615,7 +615,11 @@ func (c *clientWrapper) objectPut(ctx context.Context, prm PrmObjectPut) (oid.ID
}
var cliPrm sdkClient.PrmObjectPutInit
cliPrm.SetCopiesNumber(prm.copiesNumber) // TODO(@ironbee): adopt multiple copy number https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/44
dkirillov commented 2023-04-18 06:36:55 +00:00
Member
Copy link

With this we can just write:

cliPrm.SetCopiesNumberByVectors(prm.copiesNumberVector)
With [this](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/57/files#issuecomment-6441) we can just write: ``` cliPrm.SetCopiesNumberByVectors(prm.copiesNumberVector) ```
dkirillov marked this conversation as resolved
ironbee force-pushed add_copies_number_vector from 8f8022313b to 8611eaaeae 2023-04-18 09:05:30 +00:00 Compare
dkirillov reviewed 2023-04-18 09:31:25 +00:00
pool/pool.go Outdated
@ -1276,0 +1277,4 @@
}
// SetCopiesNumberVector sets number of object copies that is enough to consider put successful, provided as array.
// Zero means using default behavior.
dkirillov commented 2023-04-18 09:31:25 +00:00
Member
Copy link

We cannot provide "zero", so probably we can drop this comment line

We cannot provide "zero", so probably we can drop this comment line
carpawell commented 2023-04-19 13:17:31 +00:00
Contributor
Copy link

Well, I would say that it could be rephrased to "Nil/empty vector means using default behavior.", it describes the lie of the land better than nothing at all

Well, I would say that it could be rephrased to "Nil/empty vector means using default behavior.", it describes the lie of the land better than nothing at all
ironbee force-pushed add_copies_number_vector from 8611eaaeae to 1ce41bf85f 2023-04-18 09:33:12 +00:00 Compare
ironbee force-pushed add_copies_number_vector from 1ce41bf85f to 767a6a7d51 2023-04-18 09:38:04 +00:00 Compare
dkirillov approved these changes 2023-04-18 10:00:57 +00:00
ironbee requested review from storage-core-committers 2023-04-19 11:42:09 +00:00
ironbee requested review from storage-core-developers 2023-04-19 11:42:09 +00:00
carpawell requested review from fyrchik 2023-04-19 13:17:49 +00:00
ironbee force-pushed add_copies_number_vector from 767a6a7d51 to 787be46c58 2023-04-20 10:37:57 +00:00 Compare
ironbee force-pushed add_copies_number_vector from 787be46c58 to d0762d037d 2023-04-20 10:41:15 +00:00 Compare
dkirillov approved these changes 2023-04-20 10:47:21 +00:00
carpawell approved these changes 2023-04-20 10:53:32 +00:00
acid-ant approved these changes 2023-04-20 11:15:55 +00:00
fyrchik merged commit d0762d037d into master 2023-04-20 12:30:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
dkirillov
carpawell
acid-ant
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
pool

Tasks related to client pool

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
pool
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-sdk-go#57
No description provided.
Delete branch "ironbee/frostfs-sdk-go:add_copies_number_vector"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?