diff --git a/.gitlint b/.gitlint deleted file mode 100644 index a1bb93d..0000000 --- a/.gitlint +++ /dev/null @@ -1,10 +0,0 @@ -[general] -fail-without-commits=true -contrib=CC1 - -[title-match-regex] -regex=^\[\#[0-9Xx]+\]\s - -[ignore-by-title] -regex=^Release(.*) -ignore=title-match-regex diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f63f3e9..0c5b130 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -18,6 +18,15 @@ repos: - id: end-of-file-fixer exclude: "(.key|.interp|.tokens)$" + - repo: local + hooks: + - id: go-unit-tests + name: go unit tests + entry: make test GOFLAGS='' + pass_filenames: false + types: [go] + language: system + - repo: local hooks: - id: make-lint @@ -25,9 +34,3 @@ repos: entry: make lint language: system pass_filenames: false - - - repo: https://github.com/jorisroovers/gitlint - rev: v0.18.0 - hooks: - - id: gitlint - stages: [commit-msg] diff --git a/Makefile b/Makefile index 84e18a9..0b4011f 100755 --- a/Makefile +++ b/Makefile @@ -2,14 +2,15 @@ ANTLR_VERSION="4.13.0" TMP_DIR := .cache -LINT_VERSION ?= 1.55.0 +LINT_VERSION ?= 1.56.2 TRUECLOUDLAB_LINT_VERSION ?= 0.0.2 OUTPUT_LINT_DIR ?= $(shell pwd)/bin LINT_DIR = $(OUTPUT_LINT_DIR)/golangci-lint-$(LINT_VERSION)-v$(TRUECLOUDLAB_LINT_VERSION) # Run tests +test: GOFLAGS ?= "-cover -count=1" test: - @go test ./... -cover -count=1 + @GOFLAGS=$(GOFLAGS) go test ./... # Pull go dependencies dep: diff --git a/pool/pool.go b/pool/pool.go index 0b83728..7392e48 100644 --- a/pool/pool.go +++ b/pool/pool.go @@ -2049,7 +2049,7 @@ func (p *Pool) updateNodesHealth(ctx context.Context, buffers [][]float64) { wg.Add(1) bufferWeights := buffers[i] - go func(i int, innerPool *innerPool) { + go func(i int, _ *innerPool) { defer wg.Done() p.updateInnerNodesHealth(ctx, i, bufferWeights) }(i, inner) diff --git a/pool/tree/pool.go b/pool/tree/pool.go index bffe6e9..38ef09e 100644 --- a/pool/tree/pool.go +++ b/pool/tree/pool.go @@ -677,7 +677,7 @@ func (p *Pool) updateNodesHealth(ctx context.Context, buffers [][]bool) { for i, inner := range p.innerPools { wg.Add(1) - go func(i int, innerPool *innerPool) { + go func(i int, _ *innerPool) { defer wg.Done() p.updateInnerNodesHealth(ctx, i, buffers[i]) }(i, inner)