TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

bearer: Add method IsSetAPEOverride #227

Closed
acid-ant wants to merge 1 commit from acid-ant/frostfs-sdk-go:feature/token-bearer into master
pull from: acid-ant/frostfs-sdk-go:feature/token-bearer
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +7
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 2a04a40710 - Show all commits

7
bearer/bearer.go
View file

@ -313,6 +313,13 @@ func (b *Token) SetAPEOverride(v APEOverride) {
b.apeOverrideSet = true
}
// IsSetAPEOverride return true if APEOverride is set.
//
// See also: APEOverride.
func (b *Token) IsSetAPEOverride() bool {
fyrchik commented 2024-06-04 08:01:15 +00:00
Review
Copy link

Why do we need this? Empty table is valid because it is not an optional parameter.

Why do we need this? Empty table is valid because it is not an optional parameter.
acid-ant commented 2024-06-04 08:07:45 +00:00
Review
Copy link

To quickly check that table is empty, to avoid checking equality to empty.

To quickly check that table is empty, to avoid checking equality to empty.
fyrchik commented 2024-06-04 09:58:46 +00:00
Review
Copy link

I mean, when it is missing, we can assume it is present and is empty.

I mean, when it is missing, we can assume it is present and is empty.
return b.apeOverrideSet
}
// APEOverride returns APE override set by SetAPEOverride.
//
// Zero Token has zero APEOverride.