TrueCloudLab/frostfs-sdk-go
30
0
Fork 21
Code Issues 29 Pull requests 2 Releases Activity Actions

Multiple copy numbers #46

Merged
fyrchik merged 2 commits from carpawell/frostfs-sdk-go:feat/multiple-copies-number into master 2023-04-11 10:06:57 +00:00
Conversation 1 Commits 2 Files changed 4 +10 -3
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit 113271b205 - Show all commits

11
client/object_put.go
View file

@ -22,14 +22,21 @@ import (
// PrmObjectPutInit groups parameters of ObjectPutInit operation.
type PrmObjectPutInit struct {
copyNum uint32
copyNum []uint32
key *ecdsa.PrivateKey
meta v2session.RequestMetaHeader
}
// SetCopiesNumber sets number of object copies that is enough to consider put successful.
func (x *PrmObjectPutInit) SetCopiesNumber(copiesNumber uint32) {
x.copyNum = copiesNumber
x.copyNum = []uint32{copiesNumber}
}
// SetCopiesNumberByVectors sets ordered list of minimal required object copies numbers
// per placement vector. List's length MUST equal container's placement vector number,
// otherwise request will fail.
func (x *PrmObjectPutInit) SetCopiesNumberByVectors(copiesNumbers []uint32) {
x.copyNum = copiesNumbers
}
// ResObjectPut groups the final result values of ObjectPutInit operation.

2
pool/pool.go
View file

@ -617,7 +617,7 @@ func (c *clientWrapper) objectPut(ctx context.Context, prm PrmObjectPut) (oid.ID
}
var cliPrm sdkClient.PrmObjectPutInit
cliPrm.SetCopiesNumber(prm.copiesNumber)
cliPrm.SetCopiesNumber(prm.copiesNumber) // TODO(@ironbee): adopt multiple copy number https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/44
fyrchik commented 2023-04-08 05:42:02 +00:00
Review
Copy link

In TODO we mention ourselves, not those who should do the issue.

In TODO we mention ourselves, not those who should do the issue.
if prm.stoken != nil {
cliPrm.WithinSession(*prm.stoken)
}