TrueCloudLab/frostfs-sdk-go
32
0
Fork 21
Code Issues 32 Pull requests 3 Releases Activity Actions

pool: Add copies number vector when putting object #57

Merged
fyrchik merged 1 commit from ironbee/frostfs-sdk-go:add_copies_number_vector into master 2023-04-20 12:30:00 +00:00
Conversation 0 Commits 1 Files changed 1 +8 -2
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d0762d037d - Show all commits

10
pool/pool.go
View file

@ -615,7 +615,7 @@ func (c *clientWrapper) objectPut(ctx context.Context, prm PrmObjectPut) (oid.ID
}
var cliPrm sdkClient.PrmObjectPutInit
cliPrm.SetCopiesNumber(prm.copiesNumber) // TODO(@ironbee): adopt multiple copy number https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/issues/44
dkirillov marked this conversation as resolved Outdated
dkirillov commented 2023-04-18 06:36:55 +00:00
Outdated
Review
Copy link

With this we can just write:

cliPrm.SetCopiesNumberByVectors(prm.copiesNumberVector)
With [this](https://git.frostfs.info/TrueCloudLab/frostfs-sdk-go/pulls/57/files#issuecomment-6441) we can just write: ``` cliPrm.SetCopiesNumberByVectors(prm.copiesNumberVector) ```
cliPrm.SetCopiesNumberByVectors(prm.copiesNumber)
if prm.stoken != nil {
cliPrm.WithinSession(*prm.stoken)
}
@ -1257,7 +1257,7 @@ type PrmObjectPut struct {
payload io.Reader
copiesNumber uint32
copiesNumber []uint32
}
// SetHeader specifies header of the object.
@ -1273,6 +1273,12 @@ func (x *PrmObjectPut) SetPayload(payload io.Reader) {
// SetCopiesNumber sets number of object copies that is enough to consider put successful.
// Zero means using default behavior.
func (x *PrmObjectPut) SetCopiesNumber(copiesNumber uint32) {
x.copiesNumber = []uint32{copiesNumber}
}
// SetCopiesNumberVector sets number of object copies that is enough to consider put successful, provided as array.
// Nil/empty vector means using default behavior.
dkirillov commented 2023-04-18 09:31:25 +00:00
Outdated
Review
Copy link

We cannot provide "zero", so probably we can drop this comment line

We cannot provide "zero", so probably we can drop this comment line
carpawell commented 2023-04-19 13:17:31 +00:00
Outdated
Review
Copy link

Well, I would say that it could be rephrased to "Nil/empty vector means using default behavior.", it describes the lie of the land better than nothing at all

Well, I would say that it could be rephrased to "Nil/empty vector means using default behavior.", it describes the lie of the land better than nothing at all
func (x *PrmObjectPut) SetCopiesNumberVector(copiesNumber []uint32) {
x.copiesNumber = copiesNumber
}