TrueCloudLab/frostfs-testcases
26
0
Fork 21
Code Issues 2 Pull requests 3 Releases Activity Actions

[#633] object: Prevent duplicate attributes by key

Browse source 
Keys of object attributes must be unique according to NeoFS specification.

Make `FormatValidator.Validate` method to return an error if at least one
attribute is duplicated.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2021-06-23 16:30:14 +03:00 • committed by Alex Vanin
parent 6efeee5ce0
commit 01dd17e30a
2 changed files with 48 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

24
pkg/core/object/fmt_test.go
View file

@ -219,4 +219,28 @@ func TestFormatValidator_Validate(t *testing.T) {
require.NoError(t, err)
})
})
t.Run("attributes", func(t *testing.T) {
t.Run("duplication", func(t *testing.T) {
obj := blankValidObject(t, ownerKey)
a1 := object.NewAttribute()
a1.SetKey("key1")
a1.SetValue("val1")
a2 := object.NewAttribute()
a2.SetKey("key2")
a2.SetValue("val2")
obj.SetAttributes(a1, a2)
err := v.checkAttributes(obj.Object())
require.NoError(t, err)
a2.SetKey(a1.Key())
err = v.checkAttributes(obj.Object())
require.Equal(t, errDuplAttr, err)
})
})
}