From c6ebe1d67d0d43473b15f345b4d513459f75482e Mon Sep 17 00:00:00 2001 From: Vladislav Karakozov Date: Wed, 11 Jan 2023 14:58:15 +0300 Subject: [PATCH] align all nodes to be in the same epoch Signed-off-by: Vladislav Karakozov --- .../http_gate/test_http_system_header.py | 82 +++++++++++++------ robot/resources/lib/python_keywords/epoch.py | 16 +++- 2 files changed, 71 insertions(+), 27 deletions(-) diff --git a/pytest_tests/testsuites/services/http_gate/test_http_system_header.py b/pytest_tests/testsuites/services/http_gate/test_http_system_header.py index 13ac78a5..a821b54e 100644 --- a/pytest_tests/testsuites/services/http_gate/test_http_system_header.py +++ b/pytest_tests/testsuites/services/http_gate/test_http_system_header.py @@ -6,15 +6,16 @@ from typing import Optional import allure import pytest from container import create_container -from epoch import get_epoch +from epoch import align_epochs, get_epoch from file_helper import generate_file +from grpc_responses import OBJECT_NOT_FOUND from http_gate import ( attr_into_str_header_curl, get_object_and_verify_hashes, try_to_get_object_and_expect_error, upload_via_http_gate_curl, ) -from python_keywords.neofs_verbs import get_netmap_netinfo, head_object +from python_keywords.neofs_verbs import get_netmap_netinfo, get_object_from_random_node, head_object from wellknown_acl import PUBLIC_ACL from steps.cluster_test_base import ClusterTestBase @@ -230,12 +231,19 @@ class Test_http_system_header(ClusterTestBase): get_epoch(self.shell, self.cluster) == expected_epoch + 1 ), f"Epochs should be equal: {get_epoch(self.shell, self.cluster)} != {expected_epoch + 1}" - try_to_get_object_and_expect_error( - cid=user_container, - oid=oid, - error_pattern="404 Not Found", - endpoint=self.cluster.default_http_gate_endpoint, - ) + with allure.step("Check object deleted because it expires-on epoch"): + align_epochs(self.shell, self.cluster) + try_to_get_object_and_expect_error( + cid=user_container, + oid=oid, + error_pattern="404 Not Found", + endpoint=self.cluster.default_http_gate_endpoint, + ) + # check that object is not available via grpc + with pytest.raises(Exception, match=OBJECT_NOT_FOUND): + get_object_from_random_node( + self.wallet, user_container, oid, self.shell, self.cluster + ) @allure.title( f"priority of attributes duration>timestamp, duration time has higher priority and should be converted {EXPIRATION_EPOCH_HEADER}" @@ -277,12 +285,19 @@ class Test_http_system_header(ClusterTestBase): get_epoch(self.shell, self.cluster) == expected_epoch + 1 ), f"Epochs should be equal: {get_epoch(self.shell, self.cluster)} != {expected_epoch + 1}" - try_to_get_object_and_expect_error( - cid=user_container, - oid=oid, - error_pattern="404 Not Found", - endpoint=self.cluster.default_http_gate_endpoint, - ) + with allure.step("Check object deleted because it expires-on epoch"): + align_epochs(self.shell, self.cluster) + try_to_get_object_and_expect_error( + cid=user_container, + oid=oid, + error_pattern="404 Not Found", + endpoint=self.cluster.default_http_gate_endpoint, + ) + # check that object is not available via grpc + with pytest.raises(Exception, match=OBJECT_NOT_FOUND): + get_object_from_random_node( + self.wallet, user_container, oid, self.shell, self.cluster + ) @allure.title( f"priority of attributes timestamp>Expiration-RFC, timestamp has higher priority and should be converted {EXPIRATION_EPOCH_HEADER}" @@ -324,12 +339,19 @@ class Test_http_system_header(ClusterTestBase): get_epoch(self.shell, self.cluster) == expected_epoch + 1 ), f"Epochs should be equal: {get_epoch(self.shell, self.cluster)} != {expected_epoch + 1}" - try_to_get_object_and_expect_error( - cid=user_container, - oid=oid, - error_pattern="404 Not Found", - endpoint=self.cluster.default_http_gate_endpoint, - ) + with allure.step("Check object deleted because it expires-on epoch"): + align_epochs(self.shell, self.cluster) + try_to_get_object_and_expect_error( + cid=user_container, + oid=oid, + error_pattern="404 Not Found", + endpoint=self.cluster.default_http_gate_endpoint, + ) + # check that object is not available via grpc + with pytest.raises(Exception, match=OBJECT_NOT_FOUND): + get_object_from_random_node( + self.wallet, user_container, oid, self.shell, self.cluster + ) @allure.title("Test that object is automatically delete when expiration passed") @pytest.mark.parametrize( @@ -368,9 +390,17 @@ class Test_http_system_header(ClusterTestBase): assert ( get_epoch(self.shell, self.cluster) == expected_epoch + 1 ), f"Epochs should be equal: {get_epoch(self.shell, self.cluster)} != {expected_epoch + 1}" - try_to_get_object_and_expect_error( - cid=user_container, - oid=oid, - error_pattern="404 Not Found", - endpoint=self.cluster.default_http_gate_endpoint, - ) + + with allure.step("Check object deleted because it expires-on epoch"): + align_epochs(self.shell, self.cluster) + try_to_get_object_and_expect_error( + cid=user_container, + oid=oid, + error_pattern="404 Not Found", + endpoint=self.cluster.default_http_gate_endpoint, + ) + # check that object is not available via grpc + with pytest.raises(Exception, match=OBJECT_NOT_FOUND): + get_object_from_random_node( + self.wallet, user_container, oid, self.shell, self.cluster + ) diff --git a/robot/resources/lib/python_keywords/epoch.py b/robot/resources/lib/python_keywords/epoch.py index bcd80298..4315aa32 100644 --- a/robot/resources/lib/python_keywords/epoch.py +++ b/robot/resources/lib/python_keywords/epoch.py @@ -15,6 +15,7 @@ from neofs_testlib.cli import NeofsAdm, NeofsCli, NeoGo from neofs_testlib.shell import Shell from neofs_testlib.utils.wallet import get_last_address_from_wallet from payment_neogo import get_contract_hash +from test_control import wait_for_success from utility import parse_time logger = logging.getLogger("NeoLogger") @@ -33,15 +34,28 @@ def ensure_fresh_epoch( return epoch +@allure.step("Align epochs for the whole cluster") +@wait_for_success(60, 5) +def align_epochs(shell: Shell, cluster: Cluster) -> bool: + epochs = [] + for node in cluster.storage_nodes: + epochs.append(get_epoch(shell, cluster, node)) + unique_epochs = list(set(epochs)) + assert ( + len(unique_epochs) == 1 + ), f"unaligned epochs found, {epochs}, count of unique epochs {len(unique_epochs)}" + + @allure.step("Get Epoch") def get_epoch(shell: Shell, cluster: Cluster, alive_node: Optional[StorageNode] = None): alive_node = alive_node if alive_node else cluster.storage_nodes[0] + endpoint = alive_node.get_rpc_endpoint() wallet_path = alive_node.get_wallet_path() wallet_config = alive_node.get_wallet_config_path() cli = NeofsCli(shell=shell, neofs_cli_exec_path=NEOFS_CLI_EXEC, config_file=wallet_config) - epoch = cli.netmap.epoch(cluster.default_rpc_endpoint, wallet_path) + epoch = cli.netmap.epoch(endpoint, wallet_path) return int(epoch.stdout)