Add data interface test #102

Merged
d.zayakin merged 1 commit from d.zayakin/frostfs-testcases:add-test-network into master 2023-10-10 14:41:23 +00:00
Member

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>
d.zayakin requested review from qa-committers 2023-10-10 06:12:36 +00:00
d.zayakin requested review from qa-developers 2023-10-10 06:12:36 +00:00
d.zayakin force-pushed add-test-network from 144927b88d to 5a0f0fe0f6 2023-10-10 06:19:19 +00:00 Compare
anikeev-yadro approved these changes 2023-10-10 06:19:31 +00:00
abereziny reviewed 2023-10-10 07:48:05 +00:00
@ -134,0 +221,4 @@
endpoint=list_nodes[0].storage_node.get_rpc_endpoint(),
)
file_path_list.append(input_file)
assert input_file, input_file
Member

What, what?

What, what?
Author
Member

done

done
abereziny marked this conversation as resolved
abereziny reviewed 2023-10-10 07:49:08 +00:00
@ -134,0 +211,4 @@
shell=self.shell,
endpoint=nodes[0].storage_node.get_rpc_endpoint(),
)
assert "return code: 1" in excinfo.value, f"{excinfo.value}"
Member

What a strange construction...
You already using pytest.raises, why assert again?

What a strange construction... You already using pytest.raises, why assert again?
Author
Member

done

done
abereziny marked this conversation as resolved
abereziny reviewed 2023-10-10 07:51:05 +00:00
abereziny reviewed 2023-10-10 07:51:39 +00:00
@ -134,0 +175,4 @@
cid=cid,
shell=self.shell,
cluster=self.cluster,
)
Member

Up until here can be fixture like "storage_object"

Up until here can be fixture like "storage_object"
Author
Member

done

done
abereziny marked this conversation as resolved
abereziny reviewed 2023-10-10 07:53:48 +00:00
@ -134,0 +199,4 @@
cluster_state_controller.down_interface(nodes=nodes, interface=interface)
with allure.step("Tick epoch and wait 2 block"):
list_nodes = list(set(self.cluster.cluster_nodes) - set(nodes))
Member

list of which nodes?

list of which nodes?
Author
Member

done

done
abereziny marked this conversation as resolved
abereziny reviewed 2023-10-10 07:54:56 +00:00
@ -134,0 +190,4 @@
data = "data"
config_interfaces = list(nodes[0].host.config.interfaces.keys())
with allure.step(f"Get {data} in {config_interfaces}"):
list_data_interfaces = [
Member

what with all those list prefixes to variables ?

what with all those `list` prefixes to variables ?
Author
Member

done

done
abereziny marked this conversation as resolved
abereziny reviewed 2023-10-10 07:55:58 +00:00
@ -134,0 +176,4 @@
shell=self.shell,
cluster=self.cluster,
)
with allure.step("Search nodes object"):
Member

nodes with object

nodes with object
Author
Member

done

done
abereziny marked this conversation as resolved
d.zayakin force-pushed add-test-network from 5a0f0fe0f6 to 1d22162d2f 2023-10-10 14:13:47 +00:00 Compare
anikeev-yadro approved these changes 2023-10-10 14:15:41 +00:00
abereziny approved these changes 2023-10-10 14:40:38 +00:00
d.zayakin merged commit 1d22162d2f into master 2023-10-10 14:41:23 +00:00
d.zayakin deleted branch add-test-network 2023-10-10 14:41:24 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#102
No description provided.