TrueCloudLab/frostfs-testcases
24
0
Fork 19
Code Issues 2 Pull requests 3 Releases Activity Actions 2

Add test down interfaces #116

Merged
d.zayakin merged 1 commit from d.zayakin/frostfs-testcases:down-interfaces-test into master 2023-10-24 12:42:05 +00:00
Conversation 0 Commits 1 Files changed 2 +153 -5
d.zayakin commented 2023-10-23 04:45:38 +00:00
Member
Copy link

Signed-off-by: Dmitriy Zayakin d.zayakin@yadro.com

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>
d.zayakin force-pushed down-interfaces-test from 28316f94f6 to 5e64e222c5 2023-10-24 04:38:05 +00:00 Compare
d.zayakin requested review from qa-committers 2023-10-24 04:41:16 +00:00
d.zayakin requested review from qa-developers 2023-10-24 04:41:16 +00:00
anikeev-yadro approved these changes 2023-10-24 06:23:41 +00:00
JuliaKovshova approved these changes 2023-10-24 06:52:26 +00:00
abereziny reviewed 2023-10-24 08:07:16 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -325,0 +346,4 @@
simple_object_size: ObjectSize,
delete_file_after_test: None,
restore_down_interfaces: None,
data: tuple,
abereziny commented 2023-10-24 08:07:16 +00:00
Member
Copy link

That's not data :)
looks like it's interface

That's not `data` :) looks like it's `interface`
d.zayakin commented 2023-10-24 08:16:49 +00:00
Author
Member
Copy link

thanks! Done

thanks! Done
abereziny reviewed 2023-10-24 08:15:15 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -325,0 +337,4 @@
@pytest.mark.interfaces
@pytest.mark.baremetal
@pytest.mark.parametrize("data", [(Interfaces.DATA_O, Interfaces.DATA_1), (Interfaces.DATA_1, Interfaces.DATA_O)])
abereziny commented 2023-10-24 08:15:15 +00:00
Member
Copy link

also, why not

@pytest.mark.parametrize("block_iface, other_iface", [(Interfaces.DATA_O, Interfaces.DATA_1), (Interfaces.DATA_1, Interfaces.DATA_O)])

?

also, why not ``` @pytest.mark.parametrize("block_iface, other_iface", [(Interfaces.DATA_O, Interfaces.DATA_1), (Interfaces.DATA_1, Interfaces.DATA_O)]) ``` ?
d.zayakin commented 2023-10-24 08:22:19 +00:00
Author
Member
Copy link

This is also possible, just a slightly different approach. I don’t see much of a difference from what I did now.

This is also possible, just a slightly different approach. I don’t see much of a difference from what I did now.
abereziny commented 2023-10-24 11:27:12 +00:00
Member
Copy link

Your approach leads to redundant line of code

Your approach leads to redundant line of code
abereziny reviewed 2023-10-24 08:16:06 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -325,0 +393,4 @@
@pytest.mark.interfaces
@pytest.mark.baremetal
@pytest.mark.parametrize("internal", [Interfaces.INTERNAL_0, Interfaces.INTERNAL_1])
abereziny commented 2023-10-24 08:16:06 +00:00
Member
Copy link

same

same
abereziny reviewed 2023-10-24 08:16:36 +00:00
pytest_tests/testsuites/failovers/test_failover_network.py Outdated
@ -325,0 +437,4 @@
cid=cid,
shell=self.shell,
endpoint=self.cluster.default_rpc_endpoint,
timeout="60s",
abereziny commented 2023-10-24 08:16:36 +00:00
Member
Copy link

Why explicit timeout here?

Why explicit timeout here?
d.zayakin commented 2023-10-24 08:20:21 +00:00
Author
Member
Copy link

This time may be needed to synchronize internal components.

This time may be needed to synchronize internal components.
abereziny marked this conversation as resolved
d.zayakin force-pushed down-interfaces-test from 5e64e222c5 to d960a28290 2023-10-24 08:16:38 +00:00 Compare
d.zayakin force-pushed down-interfaces-test from d960a28290 to b05125af26 2023-10-24 12:15:19 +00:00 Compare
d.zayakin force-pushed down-interfaces-test from b05125af26 to 57e954ab4c 2023-10-24 12:17:42 +00:00 Compare
abereziny approved these changes 2023-10-24 12:19:52 +00:00
anikeev-yadro approved these changes 2023-10-24 12:24:31 +00:00
d.zayakin merged commit 69202cc703 into master 2023-10-24 12:42:05 +00:00
d.zayakin deleted branch down-interfaces-test 2023-10-24 12:42:08 +00:00
anikeev-yadro approved these changes 2023-10-24 12:54:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
JuliaKovshova
abereziny
anikeev-yadro
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#116
No description provided.
Delete branch "d.zayakin/frostfs-testcases:down-interfaces-test"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?