TrueCloudLab/frostfs-testcases
24
0
Fork 19
Code Issues 2 Pull requests 3 Releases Activity Actions 2

Add check for Error while deleting objects #32

Merged
JuliaKovshova merged 1 commit from EliChin/frostfs-testcases:feature/delete_objects into master 2023-05-02 12:22:09 +00:00
Conversation 0 Commits 1 Files changed 1 +3
EliChin commented 2023-04-18 14:53:59 +00:00
Member
Copy link

Signed-off-by: Liza e.chichindaeva@yadro.com

Signed-off-by: Liza <e.chichindaeva@yadro.com>
EliChin requested review from JuliaKovshova 2023-04-18 14:54:14 +00:00
EliChin requested review from abereziny 2023-04-18 14:54:14 +00:00
JuliaKovshova reviewed 2023-04-18 15:03:38 +00:00
pytest_tests/steps/s3_gate_object.py Outdated
@ -169,0 +169,4 @@
if not isinstance(s3_client, AwsCliClient):
if "Error" in response:
logger.error("Deletion failed for specific object(s)")
raise
JuliaKovshova commented 2023-04-18 15:03:35 +00:00
Member
Copy link

please raise specific error

please raise specific error
abereziny marked this conversation as resolved
abereziny requested changes 2023-04-18 16:05:20 +00:00
pytest_tests/steps/s3_gate_object.py Outdated
@ -166,6 +166,10 @@ def delete_object_s3(
def delete_objects_s3(s3_client, bucket: str, object_keys: list):
try:
response = s3_client.delete_objects(Bucket=bucket, Delete=_make_objs_dict(object_keys))
if not isinstance(s3_client, AwsCliClient):
abereziny commented 2023-04-18 16:05:16 +00:00
Member
Copy link

What about boto3 client?

Also, I think it's bad practice to check errors here since we may have negative cases like this one:
https://git.frostfs.info/TrueCloudLab/frostfs-testcases/src/branch/master/pytest_tests/testsuites/services/s3_gate/test_s3_object.py#L531

This test will be broken after such changes.

What about boto3 client? Also, I think it's bad practice to check errors here since we may have negative cases like this one: https://git.frostfs.info/TrueCloudLab/frostfs-testcases/src/branch/master/pytest_tests/testsuites/services/s3_gate/test_s3_object.py#L531 This test will be broken after such changes.
EliChin commented 2023-04-20 15:22:50 +00:00
Author
Member
Copy link

I think it's a bad practice here to add this check in aaaall separate testcases, so I tried to check it more precisely here so that no problem will be with negative tests.

I think it's a bad practice here to add this check in aaaall separate testcases, so I tried to check it more precisely here so that no problem will be with negative tests.
abereziny commented 2023-04-21 08:46:30 +00:00
Member
Copy link

Is the OBJECT_NOT_FOUND the one and only error which we want to check?

This can be simplified to just:

assert "Errors" not in response, f"The following objects have not been <...>"

The must have here is to preserve original error messages in a some way in our exception.

Is the OBJECT_NOT_FOUND the one and only error which we want to check? This can be simplified to just: ``` assert "Errors" not in response, f"The following objects have not been <...>" ``` The must have here is to preserve original error messages in a some way in our exception.
abereziny marked this conversation as resolved
abereziny reviewed 2023-04-18 16:09:49 +00:00
pytest_tests/steps/s3_gate_object.py Outdated
@ -168,1 +168,4 @@
response = s3_client.delete_objects(Bucket=bucket, Delete=_make_objs_dict(object_keys))
if not isinstance(s3_client, AwsCliClient):
if "Error" in response:
logger.error("Deletion failed for specific object(s)")
abereziny commented 2023-04-18 16:09:49 +00:00
Member
Copy link

It would be nice to include error message in logger output

It would be nice to include error message in logger output
abereziny marked this conversation as resolved
EliChin force-pushed feature/delete_objects from 1951d2e898 to 962fb6847b 2023-04-20 15:19:36 +00:00 Compare
EliChin requested review from abereziny 2023-04-20 15:24:12 +00:00
abereziny requested review from qa-developers 2023-04-21 08:23:53 +00:00
abereziny requested review from qa-committers 2023-04-21 08:23:53 +00:00
EliChin force-pushed feature/delete_objects from 962fb6847b to 10a9d9b707 2023-04-24 12:34:58 +00:00 Compare
abereziny approved these changes 2023-04-25 08:21:34 +00:00
abereziny reviewed 2023-04-25 08:21:58 +00:00
pytest_tests/steps/s3_gate_object.py Outdated
@ -8,6 +9,7 @@ import allure
import pytest
import urllib3
from botocore.exceptions import ClientError
from frostfs_testlib.resources.common import OBJECT_NOT_FOUND
abereziny commented 2023-04-25 08:21:58 +00:00
Member
Copy link

It's not required anymore

It's not required anymore
EliChin commented 2023-04-25 09:25:44 +00:00
Author
Member
Copy link

deleted

deleted
abereziny marked this conversation as resolved
abereziny reviewed 2023-04-25 08:22:02 +00:00
pytest_tests/steps/s3_gate_object.py Outdated
@ -1,5 +1,6 @@
import logging
import os
import re
abereziny commented 2023-04-25 08:22:02 +00:00
Member
Copy link

It's not required anymore

It's not required anymore
EliChin commented 2023-04-25 09:25:59 +00:00
Author
Member
Copy link

deleted

deleted
abereziny marked this conversation as resolved
EliChin force-pushed feature/delete_objects from 10a9d9b707 to 91b8fefed6 2023-04-25 09:17:00 +00:00 Compare
EliChin requested review from abereziny 2023-04-25 09:26:09 +00:00
EliChin requested review from qa-committers 2023-04-25 09:26:40 +00:00
anikeev-yadro approved these changes 2023-04-25 09:29:31 +00:00
abereziny approved these changes 2023-04-25 10:28:44 +00:00
abereziny requested review from qa-developers 2023-04-25 10:29:36 +00:00
abereziny approved these changes 2023-04-25 10:29:47 +00:00
abereziny requested review from anikeev-yadro 2023-04-25 11:00:20 +00:00
anikeev-yadro approved these changes 2023-04-25 16:59:48 +00:00
EliChin force-pushed feature/delete_objects from 91b8fefed6 to 532d58abc7 2023-05-02 08:12:20 +00:00 Compare
JuliaKovshova approved these changes 2023-05-02 12:21:06 +00:00
JuliaKovshova merged commit 532d58abc7 into master 2023-05-02 12:22:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
abereziny
anikeev-yadro
JuliaKovshova
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#32
No description provided.
Delete branch "EliChin/frostfs-testcases:feature/delete_objects"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?