TrueCloudLab/frostfs-testcases
24
0
Fork 19
Code Issues 2 Pull requests 1 Releases Activity Actions

Add test for putting object while one node is stopped #33

Merged
abereziny merged 1 commit from EliChin/frostfs-testcases:feature/node_mng into master 2023-04-21 08:00:01 +00:00
Conversation 1 Commits 1 Files changed 1 +35 -1
EliChin commented 2023-04-19 08:04:18 +00:00
Member
Copy link

Signed-off-by: Liza e.chichindaeva@yadro.com

Signed-off-by: Liza <e.chichindaeva@yadro.com>
EliChin requested review from JuliaKovshova 2023-04-19 08:04:30 +00:00
EliChin requested review from abereziny 2023-04-19 08:04:30 +00:00
EliChin requested review from qa-developers 2023-04-19 08:19:51 +00:00
abereziny reviewed 2023-04-19 08:24:37 +00:00
pytest_tests/testsuites/network/test_node_management.py Outdated
@ -415,0 +441,4 @@
endpoint=random_node.get_rpc_endpoint(),
)
wait_object_replication(cid, oid, 3, shell=self.shell, nodes=storage_nodes)
stop_random_storage_nodes(1, [random_node])
abereziny commented 2023-04-19 08:24:37 +00:00
Member
Copy link

before messing with the node we need to save it to list of after-test recovery.
See line 153 of this file.

before messing with the node we need to save it to list of after-test recovery. See line 153 of this file.
abereziny reviewed 2023-04-19 08:25:36 +00:00
pytest_tests/testsuites/network/test_node_management.py Outdated
@ -415,0 +449,4 @@
shell=self.shell,
endpoint=alive_node.get_rpc_endpoint(),
)
start_storage_nodes([random_node])
abereziny commented 2023-04-19 08:25:36 +00:00
Member
Copy link

self.return_nodes(alive_node)

`self.return_nodes(alive_node)`
abereziny reviewed 2023-04-19 08:29:41 +00:00
pytest_tests/testsuites/network/test_node_management.py Outdated
@ -415,0 +440,4 @@
shell=self.shell,
endpoint=random_node.get_rpc_endpoint(),
)
wait_object_replication(cid, oid, 3, shell=self.shell, nodes=storage_nodes)
abereziny commented 2023-04-19 08:29:41 +00:00
Member
Copy link

How lines 436-443 relates to this test?

How lines 436-443 relates to this test?
EliChin force-pushed feature/node_mng from 86b1a2fc63 to 42bd0849d0 2023-04-19 16:16:13 +00:00 Compare
EliChin force-pushed feature/node_mng from 70dd08f45a to d10095d4e5 2023-04-19 16:32:36 +00:00 Compare
EliChin force-pushed feature/node_mng from d10095d4e5 to 0bbb413224 2023-04-20 06:12:13 +00:00 Compare
yadro-vavdeev approved these changes 2023-04-20 07:28:29 +00:00
pytest_tests/testsuites/network/test_node_management.py Outdated
@ -415,0 +435,4 @@
)
with allure.step(f"Stop a random node and try to put an object"):
check_nodes.append(random_node)
stop_random_storage_nodes(1, [random_node])
yadro-vavdeev commented 2023-04-20 07:11:20 +00:00
Contributor
Copy link
random_node.stop_service()
``` random_node.stop_service() ```
EliChin commented 2023-04-20 15:00:40 +00:00
Author
Member
Copy link

changed

changed
abereziny approved these changes 2023-04-20 10:39:38 +00:00
anikeev-yadro commented 2023-04-20 11:35:18 +00:00
Member
Copy link

Where can I read the test steps?
Steps should be described in the test code or test analytic system.

Where can I read the test steps? Steps should be described in the test code or test analytic system.
JuliaKovshova approved these changes 2023-04-20 14:03:10 +00:00
EliChin force-pushed feature/node_mng from 0bbb413224 to e86ed765b1 2023-04-20 14:40:55 +00:00 Compare
EliChin requested review from yadro-vavdeev 2023-04-20 14:48:14 +00:00
EliChin requested review from abereziny 2023-04-20 14:48:20 +00:00
abereziny approved these changes 2023-04-20 15:01:53 +00:00
anikeev-yadro approved these changes 2023-04-20 15:11:28 +00:00
abereziny scheduled this pull request to auto merge when all checks succeed 2023-04-20 15:19:30 +00:00
abereziny requested review from qa-committers 2023-04-20 15:20:18 +00:00
abereziny requested review from qa-developers 2023-04-20 15:20:18 +00:00
abereziny approved these changes 2023-04-20 15:20:25 +00:00
anikeev-yadro approved these changes 2023-04-20 15:27:43 +00:00
yadro-vavdeev approved these changes 2023-04-21 05:40:04 +00:00
abereziny merged commit e86ed765b1 into master 2023-04-21 08:00:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
JuliaKovshova
abereziny
anikeev-yadro
yadro-vavdeev
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#33
No description provided.
Delete branch "EliChin/frostfs-testcases:feature/node_mng"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?