Refine CODEOWNERS settings #339

potyarkin · 2024-12-10T13:11:49Z

potyarkin commented

2024-12-10 13:11:49 +00:00

CODEOWNERS file specifies reviewers which will be automatically added to each PR.

Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools:

Filepaths are matched using Golang regex library instead of simple fileglobs
All matching lines are active instead of only the first one
There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name)

This PR is a part of multirepo cleanup effort: TrueCloudLab/frostfs-infra#90

CODEOWNERS file specifies reviewers which will be automatically added to each PR. Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools: - Filepaths are matched using Golang regex library instead of simple fileglobs - All matching lines are active instead of only the first one - There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name) This PR is a part of multirepo cleanup effort: https://git.frostfs.info/TrueCloudLab/frostfs-infra/issues/90

potyarkin added 1 commit 2024-12-10 13:11:49 +00:00

[#] Refine CODEOWNERS settings

DCO check / DCO (pull_request) Failing after 3m13s

Details

7165b04545

Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>

requested reviews from abereziny, d.zayakin, anikeev-yadro, anurindm, ylukoyan, i.niyazov, JuliaKovshova

2024-12-10 13:11:49 +00:00

potyarkin force-pushed feature/codeowners from 7165b04545 to d882356a10

2024-12-10 13:20:31 +00:00

Compare

abereziny requested changes 2024-12-11 16:16:50 +00:00

Dismissed

CODEOWNERS

					
				@ -1 +1,3 @@

				*       @JuliaKovshova @abereziny @d.zayakin @anikeev-yadro @anurindm @ylukoyan @i.niyazov

				.*          @TrueCloudLab/qa-committers

				.forgejo/.* @potyarkin

				Makefile    @potyarkin

abereziny commented

2024-12-11 16:16:49 +00:00

I wouldn't agree with that line.
Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers

I wouldn't agree with that line. Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers

potyarkin commented

2024-12-12 07:24:23 +00:00

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.

abereziny commented

2024-12-12 14:54:59 +00:00

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.

Does that means that without your approval we can't proceed with changes in Makefile?

> That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me. Does that means that without your approval we can't proceed with changes in Makefile?

potyarkin commented

2024-12-12 15:01:30 +00:00

CODEOWNERS just means that a review request will be sent to me.

But in this repo branch protection rules also "Block merge on official review requests" so yes, technically a PR can not proceed without my approval. In reality, anyone authorized to merge the PR can remove an outstanding review request and merge it anyways (wastebin button in screenshot below). This action will be logged but Forgejo will not interfere in any way.

CODEOWNERS just means that a review request will be sent to me. But in this repo branch protection rules also "Block merge on official review requests" so yes, technically a PR can not proceed without my approval. In reality, anyone authorized to merge the PR can remove an outstanding review request and merge it anyways (wastebin button in screenshot below). This action will be logged but Forgejo will not interfere in any way. ![image](/attachments/691eca8d-6735-4b64-97ee-1152724cc74d)

image.png

5.6 KiB

abereziny marked this conversation as resolved

abereziny approved these changes 2024-12-13 08:09:50 +00:00

d.zayakin approved these changes 2024-12-17 10:48:41 +00:00

removed review requests for anikeev-yadro, anurindm, ylukoyan, i.niyazov, JuliaKovshova

2024-12-17 10:55:06 +00:00

abereziny merged commit 48b97404ce into master

2024-12-25 08:47:28 +00:00

abereziny referenced this pull request from a commit

2024-12-25 08:47:31 +00:00

[#339] Refine CODEOWNERS settings