TrueCloudLab/frostfs-testcases
24
0
Fork 19
Code Issues 2 Pull requests 3 Releases Activity Actions 2

Test for invalid location constraint #38

Merged
ylukoyan merged 1 commit from EliChin/frostfs-testcases:feature/loc_constrain into master 2023-05-18 13:49:49 +00:00
Conversation 0 Commits 1 Files changed 2 +7 -1
EliChin commented 2023-05-05 10:11:48 +00:00
Member
Copy link

Signed-off-by: Liza e.chichindaeva@yadro.com

Signed-off-by: Liza <e.chichindaeva@yadro.com>
EliChin requested review from JuliaKovshova 2023-05-05 10:12:06 +00:00
EliChin requested review from abereziny 2023-05-05 10:12:07 +00:00
EliChin requested review from qa-committers 2023-05-05 10:12:07 +00:00
EliChin requested review from qa-developers 2023-05-05 10:12:08 +00:00
abereziny reviewed 2023-05-16 08:43:58 +00:00
pytest_tests/testsuites/services/s3_gate/test_s3_policy.py Outdated
@ -120,2 +120,4 @@
print(policy_1)
@allure.title("Test S3: bucket with unexisting location constraint")
def test_s3_bucket_wrong_location(self):
abereziny commented 2023-05-16 08:43:58 +00:00
Member
Copy link

Please rebase to master

After rebase should look like this:

    @allure.title("Test S3: bucket with unexisting location constraint")
    def test_s3_bucket_wrong_location(self, s3_client: S3ClientWrapper):
        with allure.step("Create bucket with unenxisting location constraint policy"):
            with pytest.raises(Exception):
                s3_client.create_bucket(location_constraint="UNEXISTING LOCATION CONSTRAINT")
Please rebase to master After rebase should look like this: ``` @allure.title("Test S3: bucket with unexisting location constraint") def test_s3_bucket_wrong_location(self, s3_client: S3ClientWrapper): with allure.step("Create bucket with unenxisting location constraint policy"): with pytest.raises(Exception): s3_client.create_bucket(location_constraint="UNEXISTING LOCATION CONSTRAINT") ```
EliChin commented 2023-05-18 07:54:04 +00:00
Author
Member
Copy link

rebased

rebased
ylukoyan requested review from ylukoyan 2023-05-17 08:17:50 +00:00
ylukoyan requested changes 2023-05-17 08:18:32 +00:00
ylukoyan left a comment
Member
Copy link

+1 to Andrey's comment

+1 to Andrey's comment
👍 1
JuliaKovshova approved these changes 2023-05-17 08:22:48 +00:00
pytest_tests/testsuites/services/s3_gate/test_s3_policy.py Outdated
@ -122,0 +122,4 @@
@allure.title("Test S3: bucket with unexisting location constraint")
def test_s3_bucket_wrong_location(self):
with allure.step("Create bucket with unenxisting location constraint policy"):
with pytest.raises(Exception):
JuliaKovshova commented 2023-05-15 10:03:12 +00:00
Member
Copy link

please add text for error

please add text for error
EliChin commented 2023-05-18 07:47:07 +00:00
Author
Member
Copy link

the error message will come from the create bucket method, and it's the needed one about wrong loc constraint

the error message will come from the `create bucket` method, and it's the needed one about wrong loc constraint
EliChin force-pushed feature/loc_constrain from 94960c9a9e to aa067d85a7 2023-05-18 07:53:41 +00:00 Compare
EliChin requested review from ylukoyan 2023-05-18 07:54:17 +00:00
JuliaKovshova requested review from qa-committers 2023-05-18 12:50:24 +00:00
JuliaKovshova requested review from qa-developers 2023-05-18 12:50:24 +00:00
JuliaKovshova approved these changes 2023-05-18 12:50:31 +00:00
abereziny approved these changes 2023-05-18 13:41:22 +00:00
abereziny approved these changes 2023-05-18 13:41:49 +00:00
pytest_tests/resources/files/policy.json
@ -2,3 +2,3 @@
"complex": "REP 1 IN X CBF 1 SELECT 1 FROM * AS X"
}
}
abereziny commented 2023-05-18 13:41:44 +00:00
Member
Copy link

Yet I don't understand why this file was touched :D

Yet I don't understand why this file was touched :D
ylukoyan approved these changes 2023-05-18 13:49:31 +00:00
ylukoyan merged commit 5be478e577 into master 2023-05-18 13:49:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
JuliaKovshova
abereziny
ylukoyan
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testcases#38
No description provided.
Delete branch "EliChin/frostfs-testcases:feature/loc_constrain"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?