Fixed typo in test_s3_delete_versioning case assertion #47

ylukoyan · 2023-05-24T14:21:05Z

ylukoyan commented

2023-05-24 14:21:05 +00:00

No description provided.

ylukoyan added 1 commit 2023-05-24 14:21:08 +00:00

Fixed typo in test_s3_delete_versioning case assertion 127895ef57

ylukoyan requested review from JuliaKovshova 2023-05-24 14:21:37 +00:00

ylukoyan requested review from anikeev-yadro 2023-05-24 14:21:37 +00:00

ylukoyan requested review from abereziny 2023-05-24 14:21:37 +00:00

ylukoyan requested review from qa-committers 2023-05-24 14:21:37 +00:00

ylukoyan requested review from qa-developers 2023-05-24 14:21:37 +00:00

JuliaKovshova approved these changes 2023-05-25 06:37:46 +00:00

abereziny reviewed 2023-05-25 09:03:57 +00:00

pytest_tests/testsuites/services/s3_gate/test_s3_object.py

					
				@ -316,3 +316,3 @@

				            }

				            assert obj_versions == {version_id_2}, f"Object should have versions: {version_id_2}"

				            assert "DeleteMarkers" not in delete_obj.keys(), "Delete markers not found"

				            assert "DeleteMarker" not in delete_obj.keys(), "Delete markers should not be created"

abereziny commented

2023-05-25 09:03:57 +00:00

There is no DeleteMarker field in DeleteObject response, Delete Marker is returned as VersionId field.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObject.html

According to https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectVersions.html
DeleteMarkers may be returned in List_Object_Version call.

And it is in the test results:

COMMAND: 'S3 List objects versions result'
OUTPUT:
{'ResponseMetadata': {'RequestId': '629cff54-020a-4632-980f-da468c80d499', 'HostId': '', 'HTTPStatusCode': 200, 'HTTPHeaders': {'x-amz-request-id': '629cff54-020a-4632-980f-da468c80d499', 'date': 'Mon, 22 May 2023 04:40:40 GMT', 'content-length': '1029', 'content-type': 'text/xml; charset=utf-8'}, 'RetryAttempts': 0}, 'IsTruncated': False, 'KeyMarker': '', 'VersionIdMarker': '', 'Versions': [{'ETag': '78d5be015ffb4cf0a4da12f9f6dcf4eb898143910c6f90a9492bf0d243431966', 'Size': 201327592, 'Key': 'edd13d46-b134-4c63-89b5-0ae1f8ab390e', 'VersionId': 'C6rRavrqKXWGL17G8G8YqX3yx5886wgzrgAoyUhZLeVx', 'IsLatest': False, 'LastModified': datetime.datetime(2023, 5, 22, 4, 39, 4, tzinfo=tzlocal()), 'Owner': {'DisplayName': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB', 'ID': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB'}}], 'DeleteMarkers': [{'Owner': {'DisplayName': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB', 'ID': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB'}, 'Key': 'edd13d46-b134-4c63-89b5-0ae1f8ab390e', 'VersionId': 'AMZmZ9gtZXGriAtorkctp6TJC1B7EN2EtQ4crpwAzYhk', 'IsLatest': True, 'LastModified': datetime.datetime(2023, 5, 22, 4, 39, 9, tzinfo=tzlocal())}], 'Name': 'f7b6a53d-0143-48b2-812f-5af9a11c631f'}

Could you please clarify?

There is no `DeleteMarker` field in DeleteObject response, Delete Marker is returned as `VersionId` field. https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteObject.html According to https://docs.aws.amazon.com/AmazonS3/latest/API/API_ListObjectVersions.html `DeleteMarkers` may be returned in List_Object_Version call. And it is in the test results: ``` COMMAND: 'S3 List objects versions result' OUTPUT: {'ResponseMetadata': {'RequestId': '629cff54-020a-4632-980f-da468c80d499', 'HostId': '', 'HTTPStatusCode': 200, 'HTTPHeaders': {'x-amz-request-id': '629cff54-020a-4632-980f-da468c80d499', 'date': 'Mon, 22 May 2023 04:40:40 GMT', 'content-length': '1029', 'content-type': 'text/xml; charset=utf-8'}, 'RetryAttempts': 0}, 'IsTruncated': False, 'KeyMarker': '', 'VersionIdMarker': '', 'Versions': [{'ETag': '78d5be015ffb4cf0a4da12f9f6dcf4eb898143910c6f90a9492bf0d243431966', 'Size': 201327592, 'Key': 'edd13d46-b134-4c63-89b5-0ae1f8ab390e', 'VersionId': 'C6rRavrqKXWGL17G8G8YqX3yx5886wgzrgAoyUhZLeVx', 'IsLatest': False, 'LastModified': datetime.datetime(2023, 5, 22, 4, 39, 4, tzinfo=tzlocal()), 'Owner': {'DisplayName': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB', 'ID': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB'}}], 'DeleteMarkers': [{'Owner': {'DisplayName': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB', 'ID': 'NajEagWVc43VD6A6oHspof6CN8sVf8m3XB'}, 'Key': 'edd13d46-b134-4c63-89b5-0ae1f8ab390e', 'VersionId': 'AMZmZ9gtZXGriAtorkctp6TJC1B7EN2EtQ4crpwAzYhk', 'IsLatest': True, 'LastModified': datetime.datetime(2023, 5, 22, 4, 39, 9, tzinfo=tzlocal())}], 'Name': 'f7b6a53d-0143-48b2-812f-5af9a11c631f'} ``` Could you please clarify?

abereziny commented

2023-05-25 12:27:33 +00:00

Clarified in DM

abereziny marked this conversation as resolved

abereziny requested changes 2023-05-25 09:06:19 +00:00

abereziny left a comment

Please clarify test flow

abereziny approved these changes 2023-05-25 12:27:40 +00:00

anikeev-yadro approved these changes 2023-05-25 15:53:51 +00:00

ylukoyan merged commit e36e18dc57 into master

2023-05-25 15:58:05 +00:00

ylukoyan deleted branch typo