TrueCloudLab/frostfs-testcases
25
0
Fork 21
Code Issues 2 Pull requests 3 Releases Activity Actions

Refine CODEOWNERS settings #339

Open
potyarkin wants to merge 1 commit from potyarkin/frostfs-testcases:feature/codeowners into master
pull from: potyarkin/frostfs-testcases:feature/codeowners
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 1 +3 -1
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit d882356a10 - Show all commits

4
CODEOWNERS
View file

@ -1 +1,3 @@
* @JuliaKovshova @abereziny @d.zayakin @anikeev-yadro @anurindm @ylukoyan @i.niyazov
.* @TrueCloudLab/qa-committers
.forgejo/.* @potyarkin
Makefile @potyarkin
abereziny marked this conversation as resolved
abereziny commented 2024-12-11 16:16:49 +00:00
Review
Copy link

I wouldn't agree with that line.
Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers

I wouldn't agree with that line. Makefile contains tests scripts which used in testing platform, so it's also @TrueCloudLab/qa-committers
potyarkin commented 2024-12-12 07:24:23 +00:00
Review
Copy link

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.
abereziny commented 2024-12-12 14:54:59 +00:00
Review
Copy link

That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me.

Does that means that without your approval we can't proceed with changes in Makefile?

> That's the quirk of Forgejo CODEOWNERS parser: it creates review requests for ALL matching lines, not just for the last one. So for Makefile changes reviewers will be both qa-commiters and me. Does that means that without your approval we can't proceed with changes in Makefile?
potyarkin commented 2024-12-12 15:01:30 +00:00
Review
Copy link

CODEOWNERS just means that a review request will be sent to me.

But in this repo branch protection rules also "Block merge on official review requests" so yes, technically a PR can not proceed without my approval. In reality, anyone authorized to merge the PR can remove an outstanding review request and merge it anyways (wastebin button in screenshot below). This action will be logged but Forgejo will not interfere in any way.

image

CODEOWNERS just means that a review request will be sent to me. But in this repo branch protection rules also "Block merge on official review requests" so yes, technically a PR can not proceed without my approval. In reality, anyone authorized to merge the PR can remove an outstanding review request and merge it anyways (wastebin button in screenshot below). This action will be logged but Forgejo will not interfere in any way. ![image](/attachments/691eca8d-6735-4b64-97ee-1152724cc74d)
image.png
5.6 KiB