TrueCloudLab/frostfs-testlib
26
0
Fork 20
Code Issues 1 Pull requests 2 Releases 1 Activity Actions

Ask all QA team members for code review #378

Open
potyarkin wants to merge 1 commit from potyarkin/frostfs-testlib:config/codeowners into master
pull from: potyarkin/frostfs-testlib:config/codeowners
merge into: TrueCloudLab:master
Conversation 1 Commits 1 Files changed 1 +1 -1
potyarkin commented 2025-04-30 12:33:24 +00:00
Member
Copy link

It seems that asking all team members for code review is better than putting all review workload only on qa-committers.

Reject this PR if it does not align with how your team works.

It seems that asking all team members for code review is better than putting all review workload only on qa-committers. Reject this PR if it does not align with how your team works.
potyarkin added 1 commit 2025-04-30 12:33:24 +00:00
[#] codeowners: Ask all QA team members for code review
Some checks failed
DCO action / DCO (pull_request) Failing after 20s
Details
28c35a6e9b 
Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>
potyarkin force-pushed config/codeowners from 28c35a6e9b to c2c8b39c2c 2025-04-30 12:34:25 +00:00 Compare
potyarkin changed title from WIP: Ask all QA team members for code review to Ask all QA team members for code review 2025-04-30 12:36:04 +00:00
requested review from qa-committers 2025-04-30 12:36:05 +00:00
abereziny approved these changes 2025-04-30 13:01:53 +00:00
All checks were successful
DCO action / DCO (pull_request) Successful in 24s
Required
Details
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u config/codeowners:potyarkin-config/codeowners
git checkout potyarkin-config/codeowners
Sign in to join this conversation.
Reviewers
No reviewers
abereziny
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/frostfs-testlib#378
No description provided.
Delete branch "potyarkin/frostfs-testlib:config/codeowners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?