TrueCloudLab/frostfs-testlib
25
0
Fork 20
Code Issues Pull requests 2 Releases 1 Activity Actions

Prettify verifier messages for error rates #146

Merged
abereziny merged 1 commit from abereziny/frostfs-testlib:feature-prettify-error-messages-for-load-verifier into master 2023-12-13 15:44:54 +00:00
Conversation 0 Commits 1 Files changed 1 +24 -16
1 changed files with 24 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
src/frostfs_testlib/load/load_verifiers.py
View file

@ -44,22 +44,20 @@ class LoadVerifier:
if deleters and not delete_operations: if deleters and not delete_operations:
issues.append(f"No any delete operation was performed") issues.append(f"No any delete operation was performed")
if write_operations and writers and write_errors / write_operations * 100 > self.load_params.error_threshold: error_rate = self._get_error_rate(writers, write_operations, write_errors)
issues.append( if error_rate > self.load_params.error_threshold:
f"Write error rate is greater than threshold: {write_errors / write_operations * 100} > {self.load_params.error_threshold}" rate_str = self._get_rate_str(error_rate)
) issues.append(f"Write errors exceeded threshold: {rate_str} > {self.load_params.error_threshold}%")
if read_operations and readers and read_errors / read_operations * 100 > self.load_params.error_threshold:
issues.append( error_rate = self._get_error_rate(readers, read_operations, read_errors)
f"Read error rate is greater than threshold: {read_errors / read_operations * 100} > {self.load_params.error_threshold}" if error_rate > self.load_params.error_threshold:
) rate_str = self._get_rate_str(error_rate)
if ( issues.append(f"Read errors exceeded threshold: {rate_str} > {self.load_params.error_threshold}%")
delete_operations
and deleters error_rate = self._get_error_rate(deleters, delete_operations, delete_errors)
and delete_errors / delete_operations * 100 > self.load_params.error_threshold if error_rate > self.load_params.error_threshold:
): rate_str = self._get_rate_str(error_rate)
issues.append( issues.append(f"Delete errors exceeded threshold: {rate_str} > {self.load_params.error_threshold}%")
f"Delete error rate is greater than threshold: {delete_errors / delete_operations * 100} > {self.load_params.error_threshold}"
)
return issues return issues
@ -76,6 +74,16 @@ class LoadVerifier:
) )
return verify_issues return verify_issues
def _get_error_rate(self, vus: int, operations: int, errors: int) -> float:
if not operations or not vus:
return 0
error_rate = errors / operations * 100
return error_rate
def _get_rate_str(self, rate: float, minimal: float = 0.01) -> str:
return f"{rate:.2f}%" if rate >= minimal else f"~{minimal}%"
def _collect_verify_issues_on_process(self, label, load_summary, verification_summary) -> list[str]: def _collect_verify_issues_on_process(self, label, load_summary, verification_summary) -> list[str]:
issues = [] issues = []