TrueCloudLab/frostfs-testlib
24
0
Fork 18
Code Issues Pull requests 2 Releases 1 Activity Actions 1

Components versions check #166

Closed
mkadilov wants to merge 1 commit from (deleted):feature/components_versions_check into master
pull from: (deleted):feature/components_versions_check
merge into: TrueCloudLab:master
Conversation 0 Commits 1 Files changed 2 +16 -2
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
src/frostfs_testlib/resources/cli.py
View file

@ -6,6 +6,20 @@ FROSTFS_CLI_EXEC = os.getenv("FROSTFS_CLI_EXEC", "frostfs-cli")
FROSTFS_AUTHMATE_EXEC = os.getenv("FROSTFS_AUTHMATE_EXEC", "frostfs-s3-authmate") FROSTFS_AUTHMATE_EXEC = os.getenv("FROSTFS_AUTHMATE_EXEC", "frostfs-s3-authmate")
FROSTFS_ADM_EXEC = os.getenv("FROSTFS_ADM_EXEC", "frostfs-adm") FROSTFS_ADM_EXEC = os.getenv("FROSTFS_ADM_EXEC", "frostfs-adm")
FROSTFS_HTTP_EXEC = os.getenv("???", "frostfs-http-gw")
abereziny commented 2024-01-23 08:18:52 +00:00
Review
Copy link

These are already in report, no need to specify it

These are already in report, no need to specify it
FROSTFS_IR_EXEC = os.getenv("???", "frostfs-ir")
FROSTFS_S3_EXEC = os.getenv("???", "frostfs-s3-gw")
FROSTFS_STORAFE_EXEC = os.getenv("???", "frostfs-node")
FROSTFS_TREE_METRICS_EXPORTER_EXEC = os.getenv("???", "frostfs-tree-metrics-exporter")
TO_BE4FE_EXEC = os.getenv("???", "tatlin-object-be4fe")
abereziny commented 2024-01-23 08:17:40 +00:00
Review
Copy link

What is Tatlin ? This if frostfs - it cant contain anything from proprietary products

What is Tatlin ? This if frostfs - it cant contain anything from proprietary products
TO_CM_EXEC = os.getenv("???", "tatlin-object-cm")
TO_IDP_EXEC = os.getenv("???", "tatlin-object-idp")
TO_S3_AUTH = os.getenv("???", "tatlin-object-s3-auth-service")
CYP_ALERT_MANAGER_EXEC = os.getenv("???", "cyp-alert-manager")
CYP_DAC_EXEC = os.getenv("???", "cyp-dac")
CYP_RBAC = os.getenv("???", "cyp-rbac")
# Config for frostfs-adm utility. Optional if tests are running against devenv # Config for frostfs-adm utility. Optional if tests are running against devenv
FROSTFS_ADM_CONFIG_PATH = os.getenv("FROSTFS_ADM_CONFIG_PATH") FROSTFS_ADM_CONFIG_PATH = os.getenv("FROSTFS_ADM_CONFIG_PATH")

4
src/frostfs_testlib/utils/version_utils.py
View file

@ -3,7 +3,7 @@ import re
from frostfs_testlib.cli import FrostfsAdm, FrostfsCli from frostfs_testlib.cli import FrostfsAdm, FrostfsCli
from frostfs_testlib.hosting import Hosting from frostfs_testlib.hosting import Hosting
from frostfs_testlib.resources.cli import FROSTFS_ADM_EXEC, FROSTFS_AUTHMATE_EXEC, FROSTFS_CLI_EXEC, NEOGO_EXECUTABLE from frostfs_testlib.resources.cli import *
from frostfs_testlib.resources.common import DEFAULT_WALLET_CONFIG from frostfs_testlib.resources.common import DEFAULT_WALLET_CONFIG
from frostfs_testlib.shell import Shell from frostfs_testlib.shell import Shell
@ -13,7 +13,7 @@ logger = logging.getLogger("NeoLogger")
def get_local_binaries_versions(shell: Shell) -> dict[str, str]: def get_local_binaries_versions(shell: Shell) -> dict[str, str]:
versions = {} versions = {}
for binary in [NEOGO_EXECUTABLE, FROSTFS_AUTHMATE_EXEC]: for binary in [NEOGO_EXECUTABLE, FROSTFS_AUTHMATE_EXEC, FROSTFS_HTTP_EXEC, FROSTFS_IR_EXEC, FROSTFS_S3_EXEC, FROSTFS_STORAFE_EXEC, FROSTFS_TREE_METRICS_EXPORTER_EXEC, TO_BE4FE_EXEC, TO_CM_EXEC, TO_IDP_EXEC, TO_S3_AUTH, CYP_ALERT_MANAGER_EXEC, CYP_DAC_EXEC, CYP_RBAC]:
out = shell.exec(f"{binary} --version").stdout out = shell.exec(f"{binary} --version").stdout
versions[binary] = _parse_version(out) versions[binary] = _parse_version(out)