TrueCloudLab/hrw
22
0
Fork 7
Code Issues 2 Pull requests 1 Releases 2 Activity

[#2] hrw: add typed methods for hashers #3

Merged
dstepanov-yadro merged 3 commits from feat/refactor-hrw into master 2023-02-27 11:18:58 +00:00
Conversation 1 Commits 3 Files changed 4 +201 -19
dstepanov-yadro commented 2023-02-27 07:15:20 +00:00 (Migrated from github.com)
Copy link

Add generic methods for sort-methods used in node

Add generic methods for sort-methods used in node
fyrchik (Migrated from github.com) reviewed 2023-02-27 07:28:28 +00:00
fyrchik (Migrated from github.com) left a comment
Copy link

Could you also add benchstat output (or just benchmark result) in the commit message?

Could you also add `benchstat` output (or just benchmark result) in the commit message?
go.mod
@ -1,8 +1,13 @@
module github.com/TrueCloudLab/hrw
go 1.14
go 1.18
fyrchik (Migrated from github.com) commented 2023-02-27 07:25:55 +00:00
Copy link

Worth a separate commit.

Worth a separate commit.
hrw.go
fyrchik (Migrated from github.com) commented 2023-02-27 07:26:43 +00:00
Copy link

s/received/receives/
dot in the end of the comment: there is a linter which complains + Godoc is nicer.

s/received/receives/ dot in the end of the comment: there is a linter which complains + Godoc is nicer.
dstepanov-yadro (Migrated from github.com) reviewed 2023-02-27 07:53:47 +00:00
go.mod
@ -1,8 +1,13 @@
module github.com/TrueCloudLab/hrw
go 1.14
go 1.18
dstepanov-yadro (Migrated from github.com) commented 2023-02-27 07:53:47 +00:00
Copy link

fixed

fixed
dstepanov-yadro (Migrated from github.com) reviewed 2023-02-27 07:54:31 +00:00
hrw.go
dstepanov-yadro (Migrated from github.com) commented 2023-02-27 07:54:31 +00:00
Copy link

fixed

fixed
fyrchik (Migrated from github.com) reviewed 2023-02-27 09:29:01 +00:00
README.md
fyrchik (Migrated from github.com) commented 2023-02-27 09:29:01 +00:00
Copy link

BB?

`BB`?
fyrchik (Migrated from github.com) approved these changes 2023-02-27 09:29:06 +00:00
fyrchik (Migrated from github.com) reviewed 2023-02-27 09:38:44 +00:00
README.md
fyrchik (Migrated from github.com) commented 2023-02-27 09:38:44 +00:00
Copy link

Frankly, I would rather delete this from README -- raw numbers, without any explanation or meaningful implications. Or, maybe at least add CPU model/RAM capacity. Like in this diff: the numbers have changed even though for most of the benchmarks the code is the same.

Not in this PR, of course. cc @alexvanin

Frankly, I would rather delete this from README -- raw numbers, without any explanation or meaningful implications. Or, maybe at least add CPU model/RAM capacity. Like in this diff: the numbers have changed even though for most of the benchmarks the code is the same. Not in this PR, of course. cc @alexvanin
carpawell (Migrated from github.com) reviewed 2023-02-27 09:42:59 +00:00
carpawell (Migrated from github.com) left a comment
Copy link

What does the last commit mean? Also, agree with @fyrchik that comparing (before/after on the same machine) results somewhere (e.g. commit msg) would be nice.

What does the last commit mean? Also, agree with @fyrchik that comparing (before/after on the same machine) results somewhere (e.g. commit msg) would be nice.
dstepanov-yadro commented 2023-02-27 09:55:31 +00:00 (Migrated from github.com)
Copy link

What does the last commit mean? Also, agree with @fyrchik that comparing (before/after on the same machine) results somewhere (e.g. commit msg) would be nice.

git command typo, fixed.

There is no fixes in existed methods, so no diff in existed benchmarks.

> What does the last commit mean? Also, agree with @fyrchik that comparing (before/after on the same machine) results somewhere (e.g. commit msg) would be nice. git command typo, fixed. There is no fixes in existed methods, so no diff in existed benchmarks.
alexvanin (Migrated from github.com) approved these changes 2023-02-27 11:00:06 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
fyrchik
alexvanin
Labels
Clear labels   
P0

Highest

  
P1

High

  
P2

Medium

  
P3

Low

  
good first issue

Good for newcomers

  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
P0
P1
P2
P3
good first issue
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/hrw#3
No description provided.
Delete branch "feat/refactor-hrw"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?