TrueCloudLab/lego
15
0
Fork 4
Code Issues 1 Pull requests 2 Projects Releases Packages Wiki Activity

ns1: fix record creation (#2115)

Browse source
This commit is contained in:
Ludovic Fernandez 2024-02-16 21:24:58 +01:00 committed by GitHub
parent fd6047a1b8
commit 1106ad382f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/pr.yml vendored
View file

@ -13,8 +13,8 @@ jobs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
env: env:
GO_VERSION: stable GO_VERSION: stable
GOLANGCI_LINT_VERSION: ${{vars.GOLANGCI_LINT_VERSION}} GOLANGCI_LINT_VERSION: v1.56.1
HUGO_VERSION: ${{vars.HUGO_VERSION}} HUGO_VERSION: 0.117.0
CGO_ENABLED: 0 CGO_ENABLED: 0
LEGO_E2E_TESTS: CI LEGO_E2E_TESTS: CI
MEMCACHED_HOSTS: localhost:11211 MEMCACHED_HOSTS: localhost:11211

4
providers/dns/ns1/ns1.go
View file

@ -97,7 +97,9 @@ func (d *DNSProvider) Present(domain, token, keyAuth string) error {
if errors.Is(err, rest.ErrRecordMissing) || record == nil { if errors.Is(err, rest.ErrRecordMissing) || record == nil {
log.Infof("Create a new record for [zone: %s, fqdn: %s, domain: %s]", zone.Zone, info.EffectiveFQDN, domain) log.Infof("Create a new record for [zone: %s, fqdn: %s, domain: %s]", zone.Zone, info.EffectiveFQDN, domain)
record = dns.NewRecord(zone.Zone, dns01.UnFqdn(info.EffectiveFQDN), "TXT", nil, nil) // Work through a bug in the NS1 API library that causes 400 Input validation failed (Value None for field '<obj>.filters' is not of type ...)
// So the `tags` and `blockedTags` parameters should be initialized to empty.
record = dns.NewRecord(zone.Zone, dns01.UnFqdn(info.EffectiveFQDN), "TXT", make(map[string]string), make([]string, 0))
record.TTL = d.config.TTL record.TTL = d.config.TTL
record.Answers = []*dns.Answer{{Rdata: []string{info.Value}}} record.Answers = []*dns.Answer{{Rdata: []string{info.Value}}}