TrueCloudLab/linters
22
0
Fork 8
generated from TrueCloudLab/basic
Code Issues 7 Pull requests Projects Releases 1 Packages Wiki Activity Actions

[#30] noliteral: Simplify code

Browse source 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
This commit is contained in:
Alexander Chuprov 2025-03-31 12:07:22 +03:00
parent 588336678b
commit e1ec8c5a6f
Signed by: achuprov
GPG key ID: 2D916FFD803B0EDD
1 changed files with 3 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
internal/analyzers/noliteral/linter.go
View file

@ -3,6 +3,7 @@ package noliteral
import ( import (
"go/ast" "go/ast"
"go/token" "go/token"
"slices"
astutils "git.frostfs.info/TrueCloudLab/linters/pkg/ast-utils" astutils "git.frostfs.info/TrueCloudLab/linters/pkg/ast-utils"
"github.com/mitchellh/mapstructure" "github.com/mitchellh/mapstructure"
@ -85,16 +86,11 @@ func (l *noliteral) analyzeCallExpr(pass *analysis.Pass, expr *ast.CallExpr, fil
if !astutils.IsStringValue(expr.Args[0]) { if !astutils.IsStringValue(expr.Args[0]) {
alias, _ := astutils.GetAliasByPkgName(file, l.config.ConstantsPackage) alias, _ := astutils.GetAliasByPkgName(file, l.config.ConstantsPackage)
if l.config.ConstantsPackage == "" || astutils.GetPackageName(expr.Args[0]) == alias || astutils.GetPackageName(expr.Args[0]) == "" { pkgName := astutils.GetPackageName(expr.Args[0])
if l.config.ConstantsPackage == "" || pkgName == alias || pkgName == "" || slices.Contains(l.config.DisablePackages, pkgName) {
return false return false
} }
for _, pkgName := range l.config.DisablePackages {
if pkgName == astutils.GetPackageName(expr.Args[0]) {
return false
}
}
pass.Report(analysis.Diagnostic{ pass.Report(analysis.Diagnostic{
Pos: expr.Pos(), Pos: expr.Pos(),
End: expr.End(), End: expr.End(),