TrueCloudLab/linters
22
0
Fork 8
generated from TrueCloudLab/basic
Code Issues 6 Pull requests Projects Releases 1 Packages Wiki Activity Actions

Add CODEOWNERS #27

Merged
dstepanov-yadro merged 1 commit from potyarkin/linters:feature/add-codeowners into master 2025-02-17 07:25:43 +00:00
Conversation 0 Commits 1 Files changed 1 +3
potyarkin commented 2024-12-10 15:37:47 +00:00
Member
Copy link

CODEOWNERS file specifies reviewers which will be automatically added to each PR.

Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools:

  • Filepaths are matched using Golang regex library instead of simple fileglobs
  • All matching lines are active instead of only the first one
  • There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name)

This PR is a part of multirepo cleanup effort: TrueCloudLab/frostfs-infra#90

CODEOWNERS file specifies reviewers which will be automatically added to each PR. Forgejo uses a bespoke CODEOWNERS parser. It differs from most other tools: - Filepaths are matched using Golang regex library instead of simple fileglobs - All matching lines are active instead of only the first one - There is no support for defining ad-hoc groups, only org teams are supported (@TrueCloudLab/team-name) This PR is a part of multirepo cleanup effort: https://git.frostfs.info/TrueCloudLab/frostfs-infra/issues/90
potyarkin added 1 commit 2024-12-10 15:37:47 +00:00
[#] Add CODEOWNERS
All checks were successful
Tests and linters / Tests (pull_request) Successful in 4m17s
Details
Tests and linters / Lint (pull_request) Successful in 4m17s
Details
Tests and linters / Build lib (pull_request) Successful in 8m43s
Details
Tests and linters / Staticcheck (pull_request) Successful in 8m55s
Details
e8a48537b6 
Signed-off-by: Vitaliy Potyarkin <v.potyarkin@yadro.com>
potyarkin force-pushed feature/add-codeowners from e8a48537b6 to c402a75412 2024-12-10 15:54:50 +00:00 Compare
potyarkin changed title from WIP: Add CODEOWNERS to Add CODEOWNERS 2024-12-10 15:54:59 +00:00
dstepanov-yadro requested changes 2025-02-17 06:37:33 +00:00
Dismissed
CODEOWNERS Outdated
@ -0,0 +1,3 @@
.* @fyrchik
dstepanov-yadro commented 2025-02-17 06:37:30 +00:00
Member
Copy link

@TrueCloudLab/storage-core-committers @TrueCloudLab/storage-core-developers

`@TrueCloudLab/storage-core-committers @TrueCloudLab/storage-core-developers`
potyarkin commented 2025-02-17 07:19:54 +00:00
Author
Member
Copy link

Agree. Fixed.

Agree. Fixed.
potyarkin force-pushed feature/add-codeowners from c402a75412 to a8f13e9438 2025-02-17 07:18:03 +00:00 Compare
potyarkin force-pushed feature/add-codeowners from a8f13e9438 to 0db97985fe 2025-02-17 07:19:14 +00:00 Compare
dstepanov-yadro approved these changes 2025-02-17 07:25:40 +00:00
dstepanov-yadro merged commit 0db97985fe into master 2025-02-17 07:25:43 +00:00
dstepanov-yadro referenced this pull request from a commit 2025-02-17 07:25:45 +00:00
[#27] Add CODEOWNERS
potyarkin deleted branch feature/add-codeowners 2025-02-17 07:50:31 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
dstepanov-yadro
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/linters#27
No description provided.
Delete branch "potyarkin/linters:feature/add-codeowners"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?